Comment #12 on issue 583 by ReviewBoard does not verify patch when uploading

We still run in to this on an almost daily basis. In our case it happens when you post a review for a Mercurial revision that is on top of some other revisions that haven't been pushed to the server yet.

When you go to view the diff you get a message like:

Diff currently unavailable.
Error: The patch to 'tests/' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.D5U2wT' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.D5U2wT/tmpTJqk5x Hunk #1 FAILED at 86. Hunk #2 FAILED at 235. 2 out of 2 hunks FAILED -- saving rejects to file /tmp/reviewboard.D5U2wT/tmpTJqk5x-new.rej

for every file in the diff.

I think at the very least the server should perform a check when you hit the "Publish" button to make sure your diff applies before allowing you to publish it.

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to