Comment #13 on issue 583 by philip.w...@googlemail.com: ReviewBoard does not verify patch when uploading
http://code.google.com/p/reviewboard/issues/detail?id=583

Bumped into this when updating a diff that had a parent with a diff that had the same parent (which I re-uploaded).

Prior to this attempt I had been able to update it fine. Now it will appear to work on the upload dialog (if I forget the parent diff it correctly prevents the upload) and fail:

The patch to '.project' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.Pqwdm6' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.Pqwdm6/tmpVG6SvM Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file /tmp/reviewboard.Pqwdm6/tmpVG6SvM-new.rej

Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.9-py2.4.egg/reviewboard/diffviewer/views.py", line 151, in view_diff
    interdiffset, highlighting, True)
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.9-py2.4.egg/reviewboard/diffviewer/diffutils.py", line 1071, in get_diff_files
    large_data=True)
File "/usr/lib/python2.4/site-packages/Djblets-0.6.19-py2.4.egg/djblets/util/misc.py", line 156, in cache_memoize
    data = lookup_callable()
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.9-py2.4.egg/reviewboard/diffviewer/diffutils.py", line 1070, in <lambda>
    enable_syntax_highlighting)),
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.9-py2.4.egg/reviewboard/diffviewer/diffutils.py", line 552, in get_chunks
    new = get_patched_file(old, filediff)
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.9-py2.4.egg/reviewboard/diffviewer/diffutils.py", line 374, in get_patched_file
    return patch(filediff.diff, buffer, filediff.dest_file)
File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6.9-py2.4.egg/reviewboard/diffviewer/diffutils.py", line 240, in patch raise Exception(_("The patch to '%s' didn't apply cleanly. The temporary " + Exception: The patch to '.project' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.Pqwdm6' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.Pqwdm6/tmpVG6SvM
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file /tmp/reviewboard.Pqwdm6/tmpVG6SvM-new.rej


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to