Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2916 by Review Board does not respect line endings

*** For customer support, please post to
*** If you have a patch, please submit it to
*** Do not post confidential information in this bug report!

What version are you running?

What's the URL of the page containing the problem?
Any diff viewer page.

What steps will reproduce the problem?
Patches downloaded from the Review Board seem to always have Unix line
endings (LF), no matter what line endings the original patch has.
I.e. if you submit a patch that contains DOS line endings (CRLF) to Review
board and then download it from the review request, the DOS line endings get
You cannot apply such a patch.

What is the expected output? What do you see instead?
What we need is for Review Board to always preserve original line endings, i.e.
an uploaded patch should not change when you download it back.
For example, if the source contains mixture of DOS and Unix line endings, it should be preserved as is,
otherwise applying the patch will fail.

What operating system are you using? What browser?
Windows/Linux, Chrome,Firefox, Opera.

Please provide any additional information below.

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to