Comment #3 on issue 2916 by Review Board does not respect line endings

Chris/David, Would it work if we make DiffParser class init do a data.splitlines(True) instead of data.splitlines(), which will keep the line-endings intact(instead of stripping it as it does now and the code manually tacking a \n at the end). We would then have to manipulate the patch method in to strip the line-endings in a way that patch can understand. That way, the data stored in filediffdata remains the same as what the user uploaded, and can be downloaded as such. Maybe Im over-simplifying this issue but thought Id check with you guys before I start on this.

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to