Comment #3 on issue 2916 by rajas...@gmail.com: Review Board does not
respect line endings
http://code.google.com/p/reviewboard/issues/detail?id=2916
Chris/David, Would it work if we make DiffParser class init do a
data.splitlines(True) instead of data.splitlines(), which will keep the
line-endings intact(instead of stripping it as it does now and the code
manually tacking a \n at the end). We would then have to manipulate the
patch method in diffutils.py to strip the line-endings in a way that patch
can understand. That way, the data stored in filediffdata remains the same
as what the user uploaded, and can be downloaded as such. Maybe Im
over-simplifying this issue but thought Id check with you guys before I
start on this.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
