Comment #3 on issue 2917 by gernhard...@googlemail.com: Invalid diffs generated by post-review for local GIT to remote SVN
http://code.google.com/p/reviewboard/issues/detail?id=2917

Okay, apparently it's not exactly the same problem for me. I switched back to 0.4.3 and applied your patch/workaround but then got errors about files not being in the repository. After taking a look at the output of "post-review --output-diff" it became evident that "git svn find-rev" produced an error if its output didn't go to the terminal:

git svn find-rev master | tee
Unable to get Terminal Size. The TIOCGWINSZ ioctl didn't work. The COLUMNS and LINES environment variables didn't work. The resize program didn't work. at /usr/lib/perl5/Term/ReadKey.pm line 362.
12477

12477 is the correct SVN revision so after changing the regex in your patch to '([0-9]+)$' I can upload reviews again.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to