Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2917 by Invalid diffs generated by post-review for local GIT to remote SVN

What version are you running?
RBTools 0.4.3

What steps will reproduce the problem?
1. Setup a remote SVN repository with content
2. Setup a local GIT repository
3. Setup RB tools appropriately
4. Fetch remote SVN files to a local GIT repository
5. Update and locally commit to GIT the file changes
6. Enter command: post-review

What is the expected output? What do you see instead?

The review is posted with the diff successfully (and the format of the diff is incorrect.)

Uploading diff, size: 59226
HTTP POSTing to <path>: {'basedir': '<base>'}
Got API Error 219 (HTTP code 400): The specified diff file is empty
Error data: {u'stat': u'fail', u'err': {u'msg': u'The specified diff file is empty', u'code': 219}}

On lines beginning with ---; the review number has a new line in it (that isn't being stripped), forcing the ) to be on a new line
On lines beginning with @@; there is invalid content after the second @@.

What operating system are you using?
Windows 7; Using Cygwin for GIT and post-review

Please provide any additional information below.

A review is created but the patch isn't uploaded. For some reason in when it is trying to retrieve the revision number, the result is coming back as a non-integer:

rev = '3759\n\x1b[?1034h'

The attached patch for masks the review number problem (it doesn't fix the root cause) and attempts to fix the @@ problem.

        gitpy.patch  233 bytes

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to