Comment #4 on issue 1524 by [email protected]: postreview.py should ignore
user configuration when generating diffs.
http://code.google.com/p/reviewboard/issues/detail?id=1524
Sorry but could the decision to add "--no-ext-diff" be please reconsidered?
I don't know what is the reasoning behind explicitly ignoring the user
options but IMHO the answer to "RB can't run the non-existent program I
configured Git to use" is simply "Don't configure Git to use non-existent
programs", not this.
And I can definitely explain why this is a problem for me: I'm using a hack
to disable diffs to some "not interesting" files by default, i.e. I
have "foobar diff=generated" in .gitattributes and used "git config
diff.generated.command true" to just suppress the diff for all files with
this attribute. Unfortunately, when I use post-review, the diffs for all
these files do get submitted, which is very annoying. And AFAICS there is
no way to avoid it.
So could the patch be either simply reverted or, if it's really needed, be
at least made optional? In the latter case, please let me know if you'd
accept a patch adding an option governing this behaviour.
TIA!
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
