Comment #8 on issue 1524 by [email protected]: postreview.py should ignore
user configuration when generating diffs.
http://code.google.com/p/reviewboard/issues/detail?id=1524
If I recall correctly, the original issue I saw is that someone can
configure external diff to run sort of graphical program that does not
actually generate a diff to stdout. If I had to guess, probably someone I
was helping had their external diff set to p4merge and couldn't figure out
why their upload wasn't working.
(As an aside, it seems that there is some debate as to whether one ought to
properly use git difftool for that purpose or git with an external diff
tool. Both seem to be possible. But the fact remains that with external
diff, there isn't a guarantee that what you get on stdout is something RB
will be able to understand once it has been uploaded.)
Perhaps RB could try without no-ext-diff but if the upload fails fallback
to no no-ext-diff before giving up?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
