Comment #5 on issue 3171 by RBTools: A critical bug for determining SCM type?

Yes, we recommend putting a .reviewboardrc in the root of each repository.

There are definitely improvements we can make to the SCM detection, and we've had a handful of similar bugs with different combinations of repositories (2785, 2801). Just using an OrderedDict may fix the issue for some but cause conflicts for others. I think ideally we want to:

- Make the perforce detection fancier than just seeing if there's a valid P4PORT and have it actually look to see if you're in a client directory. - Make the other SCM detection use a breadth-first search up the file hierarchy from the current working directory, instead of having each tool do its own depth-first search.

You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
To post to this group, send email to
Visit this group at
For more options, visit

Reply via email to