Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3171 by eyuw...@gmail.com: RBTools: A critical bug for determining SCM type?
http://code.google.com/p/reviewboard/issues/detail?id=3171

What version are you running?
RBTools 0.5.2

What's the URL of the page containing the problem?

In Previous versions (0.4.x), SCMCLIENTS was a list in which GitClient
was checked before PerforceClient.

New version (0.5.x) changed its type to be a dictionary which has no order. This makes it possible for RBTools to falsely determine the current workspace is a Perforce client if one works in both Git and Perforce and he has a global .p4config setup to pointing to a default Perforce server.

To resolve this issue, I suggested use OrderedDict() instead.

Thanks
/Eric

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to