Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3305 by david.ga...@gmail.com: ValueError: "need more than 1 value to unpack" when uploading diff for ClearCase
http://code.google.com/p/reviewboard/issues/detail?id=3305

What version are you running?
1.7.22

What's the URL of the page containing the problem?
/r/3787/

What steps will reproduce the problem?

1. Generate a diff file with appropriate metadata.
2. Navigate to /r/3787/ where 3787 is a review request for a ClearCase repo.
3. Use the "Update Diff" option. Fill in the form.
4. Press "Upload".

What is the expected output? What do you see instead?

Expected: I can update the diff without errors.
I see: "need more than 1 values to unpack"

What operating system are you using? What browser?

Linux, Firefox
(Although it doesn't matter.)

Please provide any additional information below.

The problem is that the diff file doesn't have a version selector in the second filename. That causes

    path, version = filename.split("@@", 1)

to produce

    ValueError("need more than 1 values to unpack")

for said filename. ("@@" is the separator between the file name and the version.)

I'm posting a fix for the above issue momentarily.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to