Labels: Type-Defect Priority-Medium
New issue 3335 by e.smolen...@gmail.com: RBTools - Perforce - no diffs
generated for committed changelist
*** READ THIS BEFORE POSTING!
*** You must complete this form in its entirety, or your bug report will be
*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
*** Do not post confidential information in this bug report!
What version are you running?
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1. Perforce repository: rbt post <submitted change #>
What is the expected output? What do you see instead?
Diffs are generated and a new review request is submitted. Instead, the
following error is shown:
rbtools.commands.CommandError: There don't seem to be any diffs!
What operating system are you using? What browser?
Please provide any additional information below.
There is a missing call to self._do_diff in perforce.py in the
_compute_range_changes method within the "action == 'edit'" branch of the
if/elif/else statements. I think the following should be added there:
diff_lines += self._do_diff(
old_file, new_file, initial_depot_file, initial_rev,
depot_file, 'M', ignore_unmodified=True)
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
You received this message because you are subscribed to the Google Groups
To unsubscribe from this group and stop receiving emails from it, send an email
To post to this group, send email to firstname.lastname@example.org.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.