Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3485 by s.a.hopk...@gmail.com: revision deltas on side-by-side diff screen does not work for mercurial patches
http://code.google.com/p/reviewboard/issues/detail?id=3485

What version are you running?

Review Board 2.0.2

What's the URL of the page containing the problem?

/r/16/diff/1-2/

This is purely exemplary; the problem exists with viewing deltas between revisions.

What steps will reproduce the problem?

Performing post commit review, from a branch I would like reviewed for inclusion into default, I perform the following to create the review on the server:

$ hg diff -r default >/tmp/mytmpdiff
$ cat >/tmp/mytmpdesc
Enter description of changes ...
^D
$ rbt post -o -p --markdown --diff-filename /tmp/mytmpdiff --summary "my summary" --description-file /tmp/mytmpdesc
Review request #16 posted.
...

Now, let's assume I get feedback and update my branch. I now submit an updated review as follows:

$ hg diff -r default >/tmp/mytmpdiff
$ rbt post -o -p --diff-filename /tmp/mytmpdiff -r 16 --change-description "I fixed the stuff"
Review request #16 posted.
...

Now, if I go to the diff viewer for this review, there is no difference in the diff output between viewing the following URL which displays the entire changes:

/r/16/diff/

and the following URL which purports to show the delta between the first and second set of changes:

/r/16/diff/1-2/

What is the expected output? What do you see instead?

When I perform the identical task on a separately configured repository using git instead of mercurial, I see the deltas operate properly. Viewing the /r/16/diff/1-2/ URL (eg) would correctly show the changes that were only introduced by the delta between patch changes.

What operating system are you using? What browser?

OS for web client is OS X Mavericks.  Browser is Chrome 35.0.1916.153.

Please provide any additional information below.


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to