Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3558 by matthias...@gmail.com: RB doesn't handle paths containing spaces correctly
https://code.google.com/p/reviewboard/issues/detail?id=3558

What version are you running?
Reviewboard 2.0.6
RBTools 0.6.2

What's the URL of the page containing the problem?
http://<host>/reviewboard/r/<requestnr>/diff/

What steps will reproduce the problem?
1. Have a git Repository with paths containing spaces.
2. Generate a post-commit review request using rbt post
3. View the review requests diff

What is the expected output?
File list and header of individual filediffs show full path.

What do you see instead?
In the file list I see the part of the path _after_ the space as path and beyond that the part of the path before the space, smaller, grey and italic, prepended by "Was ". Seems, a path containing one space character is interpreted as a rename.

In the header of an individual filediff, only the part before the (probably first) space is shown.

What operating system are you using? What browser?
Reviewboard and RBTools run on an up-to-date Ubuntu 12.04. I tested Chrome 37 (stable) and Firefox 32.0.

Please provide any additional information below.
Apparently, the path is already wrong when entered into the database. In the corresponding entries in diffviewer_filediff, the part of the path before the space is in the column source_file and the part after the space in the column dest_file. As a result, the source_revision entries are the same for every file in that set of file_diffs. They seem to be the hash of the first part of the path, which of course is not a git object.

Also I only tested paths containing at most one space.


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to