Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 3685 by mgul...@gmail.com: changenum cannot be updated via REST API as documented
https://code.google.com/p/reviewboard/issues/detail?id=3685

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.0.8

What's the URL of the page containing the problem?
/r/ID/

What steps will reproduce the problem?
1. Create a perforce review for a change number
2. Publish the review
3. Update the changenum via the REST API as documented here:
https://www.reviewboard.org/docs/manual/2.0/webapi/2.0/resources/review-request/#PUT
   i.e.
curl http://reviewboard.example.com/api/review-requests/8/ -X PUT -d changenum=1234

What is the expected output? What do you see instead?
The change number is not updated as expected.

What operating system are you using? What browser?
Debian 7, Chrome 37

Please provide any additional information below.
The documentation does state that the changenum is deprecated and commit_id should be used. The commit_id can be updated with the following command: curl http://reviewboard.example.com/api/review-requests/8/draft/ -X PUT -d commit_id=1234 The update succeeds, but the changenum is not updated to match, even after publishing the draft.

This wouldn't be that bad, except that the Web UI displays the changenum instead of the commit_id field. A simpler fix might be to display commit_id instead of changenum in the UI.



--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to