Comment #5 on issue 3654 by griffin....@gmail.com: HTML anchors in File
Index not working for copied files
https://code.google.com/p/reviewboard/issues/detail?id=3654
I can absolutely reproduce this in master with the built in development
webserver.
The issue appears to be on line 80 of
reviewboard/templates/diffviewer/diff_file_fragment.html. Adding <a
name="{{file.index}}" class="file-anchor"> here, similar to how it appears
on line 78, fixes the problem. However, I don't understand the surrounding
code well enough to know if this is a sufficient solution. Particularly,
it seems like the code in the prior if block (lines 77-79), which does set
an anchor name, may be intended to work in conjunction with line 80 and
that is why 80 omits the anchor name.
Please let me know if you need me to provide additional details to
replicate this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
