------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4596/
------------------------------------------------------------------------------
New update by yaqian
For Beanbag, Inc. > Review Board > Ticket #4596
Reply:
I did not find place to update the ticket, so I will just post the update
here.
For "To fix the issue, rbtool and reviewboard should have sync behavior", I
meant that rbtool and reviewboard should have same sync behavior - maybe all
use 'p4 print' with the -o option because it will preserve file
type/content/permissions according to
https://www.perforce.com/perforce/doc.current/manuals/cmdref/#CmdRef/p4_print.html
I made a change to the get_file function in
https://raw.githubusercontent.com/reviewboard/reviewboard/release-2.5.13.1/reviewboard/scmtools/perforce.py
to use the p4 print -o option (attached), that seems fixed the issue for my
team.
Files:
- perforce.py
<https://hellosplat.com/s/beanbag/attachments/1259/>
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
