------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4596/
------------------------------------------------------------------------------
New update by yaqian
For Beanbag, Inc. > Review Board > Ticket #4596
Reply:
David, upgrading p4python on the RB server did not work. The reason it’s
not working is that rbtool and the RB server are calling ‘p4 print’ differently
- rbtool (and post-review) is calling p4 print with the -o option - ‘p4 print
-o outputfile //depot/file’, see code here
https://github.com/reviewboard/rbtools/blob/master/rbtools/clients/perforce.py#L1317
(the print_file function will add the -o option); while the RB server is not –
it calls ‘p4 print //depot/file’ directly, see its code here -
https://github.com/reviewboard/reviewboard/blob/master/reviewboard/scmtools/perforce.py#L556
(the run_print function does not have the -o option)
According to the p4 print doc -
https://www.perforce.com/perforce/doc.current/manuals/cmdref/#CmdRef/p4_print.html,
the -o option redirects output to the specified output file on the local disk,
preserving the same file type, attributes, and/or permission bits as the
original file in the depot. With the -o option, the BOM characters are kept;
without it, the BOM characters are removed.
So this is an issue related to the different print behavior in
reviewboard/rbtool, triggered by the perforce 2015.2 utf8 feature. The fix is
to make post-review and review-board call p4 print in the same way. I attached
a fix in my last post, that resolved the issue for my team.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
