------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4693/
------------------------------------------------------------------------------
New ticket #4693 by alexG
For Beanbag, Inc. > Review Board
Status: New
Tags: Priority:Medium, Type:Defect
------------------------------------------------------------------------------
Long time loading diff chunks for interdiffs
==============================================================================
# What version are you running?
2.5.17
# What's the URL of the page containing the problem?
/r/\d+/diff/\d-\d/
# What steps will reproduce the problem?
1. Reviewrequest with 8 or more diff revisions with 30 or more files
If chunks are not in memcache, it will take about 1 min to load diff chunks
fo 20 files (1 page).
2. Move marker from 'orig' to 4. It will start downloading chunks for interdiff
4-8. Then move other marker to 5 (because you want diff 4-5). The first
marker will move to 'orig'(or other position), and after 1 min will start
downloading chunks for other interdiff, and it can never finish (evrything
messed-up and you may need to type 4-5 in the link and refresh page o get what
you want)
3. When you want to expand changes, it again takes long time to load 20 files
# What is the expected output? What do you see instead?
1. for issue 1, suggest to calculate chunks at the beginng(when saving new diff
in database) convert to json and save in the new table DIFF_CHUNKS with fields
(requestID, diff1,diff2, filename, chunk). Need row for every interdiff
combination. Than use the saved chunks to render them to the page. Downloading
time will always be as it taken from memcache
2. for issue 2, suggest do not send request to server on every move of the
marker, but to have refresh button for downloading new chunks
3. for issue 3, suggest to have expand button on every file-chunk html, and
expand/collaps every file separately, using ajax request
# What operating system are you using? What browser?
Ubuntu 14, 16, any browser
# Please provide any additional information below.
If you agree for these 3 proposals, I can implement them
------------------------------------------------------------------------------
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
