------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4693/
------------------------------------------------------------------------------
New update by alexG
For Beanbag, Inc. > Review Board > Ticket #4693
Reply:
Hi,
So first, let's address the slowdown. This is absolutely not normal
behavior, and points to a problem communicating with the repository. What type
of repository are you using? Can you make sure debug logging is enabled in
Admin UI -> Logging, reproduce this behavior, and then look in reviewboard.log
and look for the log timings for fetching files from the repository?
Also, what are the specs for the server you're running Review Board on?
As for the proposals:
1. This would actually make the problem worse. We calculate chunks
on-demand so that we don't have to do all of it in one HTTP request (which will
definitely time out in your situation). We also don't want to store them
permanently, as that will take up a _lot_ of space and will cause problems as
we fix or tweak the diff viewer.
2. We wouldn't want to add an explicit button (as this is not normally an
issue on installs, and people are used to the current behavior). However,
Review Board 3.0 does make improvements to the interaction with the slider
behind the scenes, being smarter about cancelling previous loads and starting
new ones.
3. I'm not opposed to having per-file full-expand buttons (we already allow
for expanding individual chunks), but it should not matter in your case. Once
the diffs have already been processed and put in memcached, an expand does not
have to re-process all the diffs.
Is it possible your memcached isn't actually working?
Status:
- New
+ NeedInfo
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
