------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4730/
------------------------------------------------------------------------------

New ticket #4730 by mgokhale-arbor
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


------------------------------------------------------------------------------
Reviewboard repository names are limited to 64 characters
==============================================================================

# What version are you running?

3.0.6

# What's the URL of the page containing the problem?

<internal>

# What steps will reproduce the problem?

We use Gitlab internally, with Reviewboard for code review. We create new 
Reviewboard repositories via a webhook in Gitlab every time a new repository is 
created.

We set the name of the repository to be the namespace of the repo in Gitlab. 
So, for example, if the project is at git.example.com/group/project, the name 
in Reviewboard will be `group/project`.

Since Gitlab has nested subgroups, sometimes the namespacing can be quite long, 
like `group/somewhat-long-subgroup-name/really-long-project-name`. Note that 
Gitlab can have more nesting of subgroups.

A few weeks ago, one of our hooks failed with a `DataError: value too long for 
type character varying(64)` -- basically it was failing to create a repo with a 
really full name, that more than 64 characters.

This seems to me to be a direct consequence of the name being limited to 64 
characters in 
https://github.com/reviewboard/reviewboard/blob/release-3.0.6/reviewboard/scmtools/models.py#L91
 (our release is 3.0.6, but it's the same in master).


I _think_ this 64-character limit is a bug since the name can be quite long if 
you include all the namespacing inherent in systems with nested groups like 
Gitlab. Would the Reviewboard devs consider bumping this to 255 characters? I 
suspect we're probably not the only ones hitting this.


------------------------------------------------------------------------------

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Reply via email to