Hi,

I was experiencing the same problem in FC8.  Just wanted to confirm
that this fix worked.

Chuck

On Sep 7, 9:26 pm, "Terry Rankine" <[EMAIL PROTECTED]> wrote:
> Hi
>
> The command that issues svn info - has funky end of line characters, which
> makes the decoding of the base url wrong, which makes the replace slashes
> command wrong, which leads to a diff which is missing the lead slashes,
> which leads to the diff being wrong.
>
> the fix? do a strip on incoming values.
>     def svn_info(self, path):
>         """Return a dict which is the result of 'svn info' at a given
> path."""
>         svninfo = {}
>         for info in execute(["svn", "info", path],
>                             split_lines=True):
>             parts = info.strip().split(": ", 1)
>
> notice the strip() hidden in the last line.
>
> Terry Rankine
>
> On Sat, Sep 6, 2008 at 6:04 AM, Nathan Heijermans <[EMAIL PROTECTED]>wrote:
>
>
>
> > I have been having the same issues with a Fedora 9 Linux install; I
> > think running Python 2.5. I tried manually filling in the summary and
> > description fields, but that still didn't work.
>
> > Nathan
>
> > Max N wrote:
> > > Hello guys. I am having issues while trying to post a diff with post-
> > > review from my windows box. I'm using the latest version of post-
> > > review, with Python2.4 and MinGW32.
>
> > > When I run "python post-review", review request is posted to the
> > > server but I see no files in it. This is the output I get running with
> > > -d (repository path changed to XXX for security reasons):
>
> > >>>> Repository info 'Path:http://devel.livra.com/svn, Base path:
> > /comparativo/frontend/cereza/trunk, Supports changesets: False'
> > >>>> svn diff --diff-cmd=diff
> > >>>> svn info
> > src/main/com/livra/cereza/application/product/MercadoLibreSearcher.java
> > >>>> svn info src/webapp/WEB-INF/web.xml
> > >>>> svn info
> > src/main/com/livra/cereza/application/product/MercadoLibreSearcher.java
> > >>>> svn info
> > src/main/com/livra/cereza/application/product/MercadoLibreSearcher.java
> > >>>> svn info
> > src/main/com/livra/cereza/application/product/MercadoLibreSearcher.java
> > >>>> svn info src/webapp/WEB-INF/web.xml
> > >>>> svn info src/webapp/WEB-INF/web.xml
> > >>>> svn info src/webapp/WEB-INF/web.xml
> > >>>> Looking for '192.168.0.38 /' cookie in C:\Documents and
> > Settings\maximiliano\Local Settings\Application
> > Data\.post-review-cookies.txt
> > >>>> Loaded valid cookie -- no login required
> > >>>> Attempting to create review request for None
> > >>>> HTTP POSTing tohttp://192.168.0.38:8123/api/json/reviewrequests/new/:
> > {'repository_path': 'http://XXX/XXX'}
> > >>>> Review request created
> > >>>> Uploading diff, size: 1534
> > >>>> HTTP POSTing to
> >http://192.168.0.38:8123/api/json/reviewrequests/8/diff/new/:{'basedir':
> > '/comparativo/frontend/cereza/trunk'}
> > > Error uploading diff: One or more fields had errors (105)
> > >>>> {u'fields': {u'path': [u'The diff file is empty']}, u'stat': u'fail',
> > u'err': {u'msg': u'One or more fields had errors', u'code': 105}}
> > > Your review request still exists, but the diff is not attached.
>
> > > Anybody have a clue that may help me find out what's going on?
>
> > > Thanks!
>
> > > Max
>
>
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to