Hi Tomash, Yeah, you'll need to have a local copy that you preferably keep in sync. In practice what you'll en dup doing is providing two diffs instead of one when updating diffs. The first is the "parent diff," a diff between some known upstream revision and the branch you're on, and then the normal diff from the beginning of that branch to HEAD.
This is a lot to do every time, so normally people use post-review for this stuff, but currently we don't support Git in post-review in this way (we only support git-svn). We definitely want support for this. It's just that nobody's had the time to write it. If you'd like to help with this, we can provide assistance where possible, or you could wait for us to implement it (likely sometime before 1.0). Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Thu, Dec 11, 2008 at 2:06 AM, Tomash <tome...@o2.pl> wrote: > > Hello, > > I'm trying to set up ReviewBoard in my company for code reviews (we're > ruby-exclusive, but I personally got attracted to Django after seeing > how easy a deployment is). The thing is, we use git with remote master > repositories (i.e. on external servers). When I add such repository to > RB and then try to submit a review request and view the submitted diff > after creating the request, I get error like this: > > fatal: Not a git repository: 'git://github.com/aenima/base-auth.git' > > Traceback (most recent call last): > File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081210- > py2.5.egg/reviewboard/diffviewer/views.py", line 86, in view_diff > files = get_diff_files(diffset, None, interdiffset, highlighting) > File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081210- > py2.5.egg/reviewboard/diffviewer/diffutils.py", line 654, in > get_diff_files > enable_syntax_highlighting) > File "/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_20081210- > py2.5.egg/reviewboard/diffviewer/diffutils.py", line 573, in > generate_files > large_data=True) > File "/usr/lib/python2.5/site-packages/Djblets-0.4.dev_20081210- > py2.5.egg/djblets/util/misc.py", line 142, in cache_memoize > data = lookup_callable() > > (etc. etc.) > > Does it mean I can't use ReviewBoard with remote git repositories and > I should create a mirror on the same server the RB is run on? > > Regards, > Tomasz Stachewicz > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
