Hello everybody,

while this is most likely not 100% related to the core Review Board
implementation (but rather to the format of the diff I am using) you
probably have an idea why my patches related to file deletions do not
apply cleanly and thus cause Review Board to bail out when trying to
display the diff using the "View Diff" button in the review request.

An example error message:
-- 8< --
The patch to 'SomeFile.java' didn't apply cleanly. The temporary files
have been left in 'c:\windows\temp\reviewboard.fuosla' for debugging
`patch` returned: patching file 'c:\windows\temp\reviewboard.fuosla\tmpje8luv'
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file
-- 8< --

The diff:
-- 8< --
--- SomeFile.java       /repos/path/to/SomeFile.java#1
+++ SomeFile.java       2009-08-14 18:19:44
@@ -1,28 +0,0 @@
-The quick brown fox jumps over the lazy dog...
-Lorem ipsum...
-- 8< --

And finally the content of tmpje8luv:
-- 8< --
The quick brown fox jumps over the lazy dog...
Lorem ipsum...
-- 8< --

As far as I can see the command line equivalent of the patch command
executed by Review Board in this example would be:
  patch -o tmpje8luv-new tmpje8luv < SomeFile.java.diff
which comes up with the same reverse patch message when I run it on
the command line.

I cannot see any obvious errors with the patch, yet, something seems
to be wrong.

Any idea?


You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
For more options, visit this group at 

Reply via email to