Opened 1378 Pv
On Oct 29, 11:34 am, Christian Hammond <chip...@chipx86.com> wrote: > Glad you figured it out. We need to check for that and fail gracefully. > Would you mind filing a bug so we can track it for the release? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Thu, Oct 29, 2009 at 11:10 AM, Pv <p...@swooby.com> wrote: > > > Yes, it was a simple diff not being in my path problem. > > > Pv > > > On Oct 29, 10:49 am, Pv <p...@swooby.com> wrote: > > > Duh! This is a "diff" problem that I ran in to before...fixing now. > > > > Pv > > > > On Oct 29, 10:43 am, Pv <p...@swooby.com> wrote: > > > > > I am doing a post-commit review on a teammate's checked in C# code on > > > > an SVN server. > > > > I run: > > > > post-review -d --revision-range=24506 > > > > > And I get the following output:>>> svn info > > > > >>> repository info: Path: svn://devsrvsea01/svnroot, Base path: > > /trunk/StopProcess, Supports changesets: False > > > > >>> svn propget reviewboard:url C:\src\trunk\StopProcess > > > > >>> svn propget reviewboard:url C:\src\trunk\ > > > > >>> svn diff --diff-cmd=diff -r 24506 > > > > > Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', '-r', > > > > '24506'] > > > > ['Index: StopProcess/obj/Debug/StopProcess.exe\n', > > > > '=================================================================== > > > > \n', 'Cannot display: file marked as a binary type.\n', 'svn:mime-type > > > > = > > > > application/octet-stream\n', 'Index: StopProcess/obj/Debug/ > > > > StopProcess.pdb\n', > > > > '=================================================================== > > > > \n', 'Cannot display: file marked as a binary > > > > type.\n', 'svn:mime-type = application/octet-stream\n', 'Index: > > > > StopProcess/obj/Debug/StopProcess.csproj.FileListAbsolute.txt\n', > > > > '============================================================ > > > > =======\n', "svn: Can't start process 'diff': The system cannot find > > > > the file specified. \n"] > > > > > I understand the origin of the error, but the code of post-review > > > > looks like it should ignore this. > > > > Am I doing something wrong? > > > > > Pv > > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegr > > oups.com> > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -~----------~----~----~----~------~----~------~--~--- --~--~---------~--~----~------------~-------~--~----~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
