Yes, I noticed the patch Friday, sweet!
One nitpick is that because I am writing a pre-commit hook to inerface
w/ RB, all I currently want is a simple list of the latest filenames
in the review (and intersect w/ a set of the filenames in the commit);
if they all exist then I check for "ship_it".
I realize just checking filenames is a bit weak, but it seems to
meet my needs for now.
I think doing more complex svn cat against reviewboard diffsets
would be too heavy for a pre-commit hook.
I currently don't care if someone wants to try to circumvent code
review enforcement by opening two reviews for a single file, get
ship_it for only one review, and then trying to check them both in.
Mak's latest patch lets me get a list of the diffsets, but then I need
to make a second JSON call to get that diffset's list of filenames.
Getting the list of filenames is what I would be submitting a patch
for.
I see three options (maybe all of them are useful):
1) diff/(?P<diffset_id>[0-9]+)/filenames/
This would return the depot_filenames of all files in that diffset.
2) reviewrequests/(?P<review_request_id>[0-9]+)/diff/latest/files/
This would return the depot_filenames of a review's latest diffset.
This avoids the need to make two JSON calls.
This should then probably be extended to get files of any review's
diff revisions:
reviewrequests/(?P<review_request_id>[0-9]+)/diff/(?
P<diff_revision>[0-9]+)/filenames/
3) reviewrequests/(?P<review_request_id>[0-9]+)/filenames/
Same result as #2, but less wordy.
I prefer this one, since this does not obligate me to also
implement:
reviewrequests/(?P<review_request_id>[0-9]+)/diff/(?
P<diff_revision>[0-9]+)/filenames/
Pv
On Nov 5, 2:49 am, Christian Hammond <chip...@chipx86.com> wrote:
> I forgot that we actually had a patch up for review for this. It's now
> committed to master and will be in the 1.1 release. We don't really want to
> add new functionality to 1.0.x without a very good reason.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Wed, Nov 4, 2009 at 11:17 PM, Christian Hammond <chip...@chipx86.com>wrote:
>
>
>
> > There's no API method for this yet. It should be easy. Would you be willing
> > to write a patch for this? It will probably be simple. And can you file a
> > feature request for this?
>
> > Christian
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
>
> > On Tue, Nov 3, 2009 at 11:03 AM, Pv <p...@swooby.com> wrote:
>
> >> I am trying to automate hooking CodeReview in to an SVN pre-commit
> >> hook.
> >> For a preview of how I am doing this see my recent comment added to:
> >>http://code.google.com/p/reviewboard/wiki/ReviewBoardAPI
>
> >> My pre-commit can get the reviewrequest and see reviewers and check
> >> for "ship_it", but now I need to be able to get the affected file set
> >> in the reviewrequest and cross-reference that the SVN commit doesn't
> >> check in any files that are not in the reviewrequest.
>
> >> I can't seem to find an API method that lets me get the total file set
> >> in a reviewrequest.
> >> I see "diff/new", but I think that just operates to create a new diff,
> >> not get a list of the existing diffs.
>
> >> Is there an API method to get the total file set of a reviewrequest?
>
> >> Thanks!
>
> >> Pv
> >> >> To unsubscribe from this group, send email to
> >> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegr
> >> oups.com>
> >> For more options, visit this group at
> >>http://groups.google.com/group/reviewboard?hl=en
> >> -~----------~----~----~----~------~----~------~--~---
--~--~---------~--~----~------------~-------~--~----~
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---
