We definitely do need this, and a way to make that known in a diff upload. Christian
-- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Jan 15, 2010 at 8:35 AM, Chris Clark <chris.cl...@ingres.com> wrote: > The last time I looked at this the real issue was that whilst Reviewboard > had the concept of a new file (i.e. ADD) there was no corresponding > remove/delete support. For out SCM I ended up make fake diffs in the SCM > parser that adds a line to the new files that says "WARNING FILE REMOVE" > > We really need file delete support/flag in Reviewboard. > > Chris > > > Scott Quesnelle wrote: > >> The problem is the way that cvs generates the diff for removed files. It >> is the same as for a file which has just been added and as such they cannot >> checkout the file correctly. I am mulling over trying to fix this bug, by >> treating the file as a 'new' file since the diff shows every line removed. >> >> Scott >> >> On Thu, Jan 14, 2010 at 10:58 PM, JohnHenry <qhlonl...@163.com <mailto: >> qhlonl...@163.com>> wrote: >> >> Hi, all. >> I am trying using post-review to generate review request for cvs >> removed files. Once a file has been removed with "cvs remove file " >> "cvs commit", Then the new version will be the removed version. >> Suppose the file version before remove is V1.1 , Then after execution >> "cvs remove" , It will be V1.2; I use the following command: >> post-review --target-people=rbroot --submit-as=new rb -- >> summary="Testing wrong" --file-name=new.c --revision-range=1.1:1.2 - >> p >> But the execution result is: >> Error uploading diff: One or more fields had errors (105) >> Your review request still exists, but the diff is not attached. >> """ >> >>> {"stat": "ok"} >> >>> Review request draft saved >> >>> Uploading diff, size: 223 >> >>> HTTP POSTing to >> http://192.168.3.20:8080/api/json/reviewrequests/204/diff/new/: {} >> >>> {"fields": {"path": ["Unable to parse diff revision header >> 'Fri Jan 15 11:57:39 2010'"]}, "stat": "fail", "err": {"msg": "One >> or more fields had errors", "code": 105}} >> Error uploading diff: One or more fields had errors (105) >> """ >> What is the "Unable to parse diff revision header " mean? >> >> Best Regards! >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> >> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> >> >> <mailto:reviewboard%2bunsubscr...@googlegroups.com<reviewboard%252bunsubscr...@googlegroups.com> >> > >> >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> >> >> > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en >
-- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
