This might be a better patch:
--- ORIGINAL-svn-hook-postcommit-review 2010-02-25 08:50:07.000000000
-0500
+++ svn-hook-postcommit-review 2010-02-25 09:09:40.000000000 -0500
@@ -221,6 +221,9 @@
if len(reviewid) == 0:
args += [summary, description, bugs]
+ # Filter out blank arguments.
+ args = [elem for elem in args if len(elem) > 1]
+
if DEBUG:
args += ['-d', '--output-diff']
print [os.path.join(POSTREVIEW_PATH, 'post-review')] + args
@@ -234,3 +237,4 @@
if __name__ == '__main__':
main()
+
On Feb 25, 8:51 am, Stodge <sto...@gmail.com> wrote:
> This patch might help:
>
> --- ORIGINAL-svn-hook-postcommit-review 2010-02-25 08:50:07.000000000
> -0500
> +++ svn-hook-postcommit-review 2010-02-25 08:49:41.000000000 -0500
> @@ -216,6 +216,9 @@
> # common arguments
> args = [repository_url, username, password, publish,
> submitas, revision, base_path, reviewid]
> +
> + # Filter out blank arguments.
> + args = [elem for elem in args if len(elem) > 1]
>
> # if not updating an existing review, add extra arguments
> if len(reviewid) == 0:
> @@ -234,3 +237,4 @@
>
> if __name__ == '__main__':
> main()
>
> On Feb 25, 7:52 am, Stodge <sto...@gmail.com> wrote:
>
> > Failed to execute command: ['svn', 'diff', '--diff-cmd=diff',
> > 'file:///
> > srv/svn/fred/@10', 'file:///srv/svn/fred/@11', '', '', '']
>
> > It's the three empty strings (last 3 params) that are causing
> > problems.
>
> > svn diff file:///srv/svn/fred/@10 file:///srv/svn/fred/@11 '' '' ''
> > svn: Target lists to diff may not contain both working copy paths and
> > URLs
>
> > Without them the command works:
>
> > svn diff file:///srv/svn/fred/@10 file:///srv/svn/fred/@11
> > Index: trunk/README.txt
>
> > Or this works too:
>
> > svn diff --old=file:///srv/svn/fred/@10 --new=file:///srv/svn/fred/@11
> > '' '' ''
> > Index: trunk/README.txt
>
> > I just don't know what this means.
>
> > On Feb 25, 7:11 am, Stodge <sto...@gmail.com> wrote:
>
> > > I'm using SVN version 1.6.9.
>
> > > On Feb 24, 9:51 pm, Christian Hammond <chip...@chipx86.com> wrote:
>
> > > > Hmm, hard to say. I'm able to do that with svn v1.3.1. Which version
> > > > are you
> > > > using?
>
> > > > Christian
>
> > > > --
> > > > Christian Hammond - chip...@chipx86.com
> > > > Review Board -http://www.reviewboard.org
> > > > VMware, Inc. -http://www.vmware.com
>
> > > > On Wed, Feb 24, 2010 at 6:01 PM, Stodge <sto...@gmail.com> wrote:
> > > > > I'm trying to get the post-review script working from the svn hook but
> > > > > I'm getting a weird error:
>
> > > > > ./rb-post-commit-hook /srv/svn/fred 11
> > > > > /usr/bin/post-review --repository-url=file:///srv/svn/fred --
> > > > > username=admin --password=admin -p --submit-as=mike --revision-
> > > > > range=10:11 --server=http://localhost/reviews/fred--summary="refs
> > > > > #1 - publish review" --description="(In [11]) refs #1 - publish
> > > > > review"
> > > > > Failed to execute command: ['/usr/bin/post-review', '--repository-
> > > > > url=file:///srv/svn/fred', '--username=admin', '--password=admin', '-
> > > > > p', '--submit-as=mike', '--revision-range=10:11', '', '', '--
> > > > > server=http://localhost/reviews/fred', '--summary="refs #1 - publish
> > > > > review"', '--description="(In [11]) refs #1 - publish review"', '']
> > > > > Failed to execute command: ['svn', 'diff', '--diff-cmd=diff',
> > > > > 'file:///
> > > > > srv/svn/fred/@10', 'file:///srv/svn/fred/@11', '', '', '']
> > > > > ['svn: Target lists to diff may not contain both working copy paths
> > > > > and URLs\n']
>
> > > > > If I type the post-review command (I used print to display what was
> > > > > being executed) then it works:
>
> > > > > /usr/bin/post-review --repository-url=file:///srv/svn/fred --
> > > > > username=admin --password=admin -p --submit-as=mike --revision-
> > > > > range=10:11 --server=http://localhost/reviews/fred--summary="refs
> > > > > #1 - publish review" --description="(In [11]) refs #1 - publish
> > > > > review"
> > > > > ==> Review Board Login Required
> > > > > Enter username and password for Review Board at
> > > > >http://localhost/reviews/fred/
> > > > > Review request #13 posted.
>
> > > > >http://localhost/reviews/fred/r/13
>
> > > > > Any ideas why it won't work when I run the post-commit hook manually?
>
> > > > > --
> > > > > Want to help the Review Board project? Donate today at
> > > > >http://www.reviewboard.org/donate/
> > > > > Happy user? Let us know athttp://www.reviewboard.org/users/
> > > > > -~----------~----~----~----~------~----~------~--~---
> > > > > To unsubscribe from this group, send email to
> > > > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> > > > > For more options, visit this group at
> > > > >http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
