Hi Michael, We at least used to have the behavior that S would receive an e-mail. Looking at the code, I'd expect it to still be working. It should be in the CC or To fields. I'm a bit unsure as to why you're not seeing S in either list.
What version of RB are you running? And if you look at all the message headers for one of those e-mails, do you not see S anywhere in it? Can you verify that it does list S as the submitter on the review request, and that S has an e-mail address associated in the database? Christian -- Christian Hammond - [email protected] Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Apr 13, 2011 at 12:16 AM, Michael Keller <[email protected]> wrote: > I feel I have been unclear in the wording of my question. > > When I create a review with post-review with submit-as S, and this > triggeres the default review groups D1 and D2 (by file regex), then only > D1 and D2 seem to receive a mail notification, but not S. So far, so good. > But now let's say, a reviewer R adds a review comment, then again > notifications only go to D1 and D2, but not to S (unless of course S is > part of D1 or D2 - but that may not be the case). Is this really the > intended behavior? Or is there something wrong with the way I set up the > review initially? > > And another question: Is it possible/planned to have default reviewers > according to submitter, rather than file regex - the standard example > being: the team leader wants to get notifications about all reviews > generated by his team members? > > Thank you very much, > Michael > > > > > From: Michael Keller/Haifa/IBM@IBMIL > To: [email protected] > Date: 04/11/2011 09:19 PM > Subject: review comments by default received by submitter > Sent by: [email protected] > > > > Hi, > > We create reviews using post-review (through a git hook). And we set up > default review groups according to code ownership. > Now it turns out, that if someone posts a review comment, the default > reviewers receive an e-mail notification, but not necessarily the > submitter (who may not be in the default reviewers list)! > I can see that the submitter is correctly resolved by reviewboard, i.e. to > > a user https://<url>/users/<e-mail>. > > Obviously I can solve this at the post-review end, but it seems like such > a sensible default, that I feel I am missing something. > > Thank you very much, > Michael > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
