Hi Sami, I'm glad that's the case :) I looked into this and didn't see a problem, but I know we had it at one point and thought it was fixed for the release.
Thanks for the update on this. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Aug 23, 2012 at 10:05 PM, Sami Paavilainen <hytty...@gmail.com>wrote: > To update on this, it turned out that this was due to a broken > installation. Sorry for the trouble. :) > > > On Saturday, 18 August 2012 12:29:25 UTC+3, Sami Paavilainen wrote: >> >> This is on version 1.6.10 of Review Board. >> >> So, the symptoms: >> The submitter is unable to add comments to review notes placed on diffs, >> and is also unable to resolve/drop issues opened on these. >> Adding comments to the review itself works without a problem. >> >> I opened firebug and had a look at this, and I think I've found what's >> happening, altough I cannot say why it would be happening. >> This piece of code from reviews.js is the culprit (at least for being >> unable to add comments): >> http://pastebin.com/XkL9PCtT >> >> (Or if you already have the source, jump to line 522 in reviews.js) >> >> This is called when clicking OK of the comment window. The reason the >> code fails for us is that the value of context_type is "diff_comment", >> which is unexpected by the following if/else tree, causing it to go through >> the branch with the comment "Shouldn't be reached", and returning without >> taking any action. >> >> Similar thing happens with the resolve/drop buttons, value of >> context_type is "diff_comment" causing the code for them to also fail. >> >> This is from the page source: >> <script language="javascript"> >> $(document).ready(function() { >> $("#rc187-49").commentSection( >> "49", >> "187", >> "diff_comments"); >> }); >> </script> >> >> So that's where the diff_comments is coming from, and this is where I'll >> stop for now. >> >> Can anyone more familiar with the code confirm this? >> >> -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
