Hello Christian.
I am not running sudo anywhere in the script.

This is the full hook script I already posted:
*=======================================repo/hooks/post-commit script paste 
start===============================================*
*REPOS="$1"*
*REV=$(($2))*
*OLDREV=$(($REV-1))*
*RBSRV="http://reviews.example.test/"*
*SVNLOOK=/usr/bin/svnlook*
*AUTHOR="$($SVNLOOK author $REPOS -r $REV)"*
*
*
*LogDir="/var/log/svn/"*
*#Get only the name of the REPOSITORY as REPOS is a filesystem path:*
*RepoName=${REPOS##*/}*
*RepoURL="http://xxx.xxx.xxx.xxx/svn/${RepoName}"*
*
*
*#Some debugging info*
*echo "=====================================" >> /srv/logs/test*
*whoami >> /srv/logs/test*
*echo "svnlook: ${SVNLOOK}" >> /srv/logs/test*
*echo "authhor: ${AUTHOR}" >> /srv/logs/test*
*echo "Commited rev: ${REV}" >> /srv/logs/test*
*echo "Old rev: ${OLDREV}" >> /srv/logs/test*
*echo "RepoName-REPOS: ${RepoName}" >> /srv/logs/test*
*echo "Repository URL: ${RepoURL}" >> /srv/logs/test*
*
*
*post-review --repository-url="${RepoURL}" 
--revision-range="${OLDREV}":"${REV}" --server="${RBSRV}" 
--username=reviewposter --password="password" --submit-as="${AUTHOR}" -p 
--target-groups=reviewers --debug >> /srv/logs/post-rev 2>&1*
*exit 0*

*=================================================repo/hooks/post-commit** 
script 
paste start**===========================================*

SELinux *is not installed.*

Test Platform Distribution is (Ubuntu 10.10): <== This is the platform on 
which I am experiencing the problem. This has not been tested on the live 
server.
*Linux xxxxxx 2.6.35-22-generic #35-Ubuntu SMP Sat Oct 16 20:45:36 UTC 2010 
x86_64 GNU/Linux*
SVN version is: *1.6.12 (r955767)*
*
*
Future Server Distribution is (Ubuntu 10.10):
*Linux xxxxxxx 2.6.32-41-server #94-Ubuntu SMP Fri Jul 6 18:15:07 UTC 2012 
x86_64 GNU/Linux*
SVN version is: *1.6.6 (r40053)*
*
*

Regards, 
    Borislav.
*
*On Thursday, 27 September 2012 10:33:54 UTC+3, Christian Hammond wrote:
>
> I didn't see it in your script, but are you running the script as sudo in 
> the hook somewhere?
>
> What distro are you running? Is SELinux turned on?
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com <javascript:>
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Wed, Sep 26, 2012 at 7:58 AM, Borislav Sabev 
> <borisl...@gmail.com<javascript:>
> > wrote:
>
>> I have also created a question over at superuser so if anyone has this 
>> issue also take a look there:
>>
>> http://superuser.com/questions/479803/permissions-issue-when-trying-to-execute-command-in-post-commit-hook-in-svn
>>
>> Cheers, 
>>     Borislav.
>>
>> On Tuesday, 25 September 2012 16:23:06 UTC+3, Borislav Sabev wrote:
>>>
>>> Hello all.
>>>
>>> I have a dull problem that I can't seem to solve.
>>>
>>> *What am I trying to do?*
>>> I am trying to do:
>>> *post-review 
>>> --repository-url=http://xxx.xxx.xxx.xxx/svn/testRepo2--revision-range=6:7 
>>> --server=
>>> http://reviews.example.test/ --username=reviewposter 
>>> --password=mydullpass --submit-as=admin -p --target-groups=reviewers*
>>> All is alright when I try this from bash logged in as my user. Review is 
>>> posted, published, etc. ==> All permissions and other miscellaneous 
>>> settings are OK.
>>>
>>> *What happens when I try this from SVN's post-commit hook?*
>>> The resources are commited but the svn operation hangs - actually the 
>>> post-commit hook does not finish.
>>>
>>> *What is the problem?*
>>> post-review seems to get the user that is executing it and tries to log 
>>> it in. The user that's executing it is www-data (apache user) I.e. when I 
>>> run the command as www-data:
>>> *sudo -u www-data post-review --repository-url=**http://xxx.
>>> xxx.xxx.xxx/svn/testRepo2** --revision-range=6:7 **--server=ht
>>> tp://reviews.example.test/** --username=reviewposter --password=**
>>> mydullpass**! --submit-as=admin -p --target-groups=reviewers -d*
>>> *
>>> *
>>> I get (notice the -d parameter in the post-review command - DEBUG):
>>> *>>> RBTools 0.4.1*
>>> *>>> Home = /home/borislav*
>>> *Password for 'www-data':*
>>>
>>> This is where it hangs waiting for a password to be entered. The commit 
>>> operation cannot finish and it just stays there. On the other hand when I 
>>> do the same command with debug output but as myuser I get:
>>> *>>> RBTools 0.4.1*
>>> *>>> Home = /home/borislav*
>>> *>>> HTTP GETting api/*
>>> *>>> HTTP GETting http://reviews.example.test/api/info/*
>>> *>>> Using the new web API*
>>> *>>> HTTP GETting http://reviews.example.test/api/repositories/*
>>> *>>> HTTP GETting http://reviews.example.test/api/repositories/1/*
>>> *>>> HTTP GETting http://reviews.example.test/api/repositories/1/info/*
>>> *>>> HTTP GETting http://reviews.example.test/api/repositories/2/*
>>> *>>> HTTP GETting http://reviews.example.test/api/repositories/2/info/*
>>> *>>> HTTP GETting http://reviews.example.test/api/repositories/3/*
>>> *>>> HTTP GETting http://reviews.example.test/api/repositories/3/info/*
>>> *>>> HTTP GETting http://reviews.example.test/api/repositories/4/*
>>> *>>> HTTP GETting http://reviews.example.test/api/repositories/4/info/*
>>> *>>> Attempting to create review request on http://xxx.xxx.xxx.xxx/svn/
>>> testRepo2 for None*
>>> *>>> Submitting the review request as admin*
>>> *>>> HTTP POSTing to http://reviews.example.test/api/review-requests/: 
>>> {'submit_as': 'admin', 'repository': 'http://xxx.xxx.xxx.xxx/svn/
>>> testRepo2'}*
>>> *>>> Review request created*
>>> *>>> Attempting to set field 'target_groups' to 'reviewers' for review 
>>> request '22'*
>>> *>>> HTTP PUTting to http://reviews.example.test/
>>> api/review-requests/22/draft/: {'target_groups': 'reviewers'}*
>>> *>>> Uploading diff, size: 2316*
>>> *>>> HTTP POSTing to http://reviews.example.test/
>>> api/review-requests/22/diffs/: {'basedir': '/'}*
>>> *>>> Publishing*
>>> *>>> HTTP PUTting to http://reviews.example.test/
>>> api/review-requests/22/draft/: {'public': 1}*
>>> *Review request #22 posted.*
>>> *
>>> *
>>> *http://reviews.example.test/r/22/*
>>> *
>>> *
>>> So actually everything with the posting/publishing etc. works.
>>>
>>> One solution I thought of is to execute the command as my user from the 
>>> post-commit hook but that seems out-stretched and ugly to me.
>>> Are there any other solutions?
>>>
>>> Thanks, 
>>>     Borislav.
>>>
>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~----------~----~----~----~------~----~------~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com <javascript:>
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to