Filed an enhancement at http://code.google.com/p/reviewboard/issues/detail?id=2840 and posted a patch at http://reviews.reviewboard.org/r/3707/
- Raja On Friday, December 28, 2012 2:42:53 AM UTC+5:30, Christian Hammond wrote: > > In theory, it could, but it would probably need a little bit of new code > to provide a signal we can emit on close/reopen. > > I wouldn't be opposed to having this feature as part of Review Board, so > long as it's optional. It's pretty minimal. > > Christian > > -- > Christian Hammond - chi...@chipx86.com <javascript:> > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Thu, Dec 27, 2012 at 6:31 AM, Michael Zhilin <miz...@gmail.com<javascript:> > > wrote: > >> Hi Christian, >> >> Could it be implemented as extension or not? >> >> Thank you, >> Michael Zhilin >> >> On Dec 26, 2012, at 23:57, Christian Hammond >> <chi...@chipx86.com<javascript:>> >> wrote: >> >> Hi Peer, >> >> We don't e-mail when closing review requests. We only e-mail for new >> updates and reviews/replies. >> >> I'd be happy to take a patch that provides it and makes it optional (off >> by default in order to not increase e-mail load). >> >> Christian >> >> >> On Dec 26, 2012, at 5:08 AM, Peer <peerm...@gmail.com <javascript:>> >> wrote: >> >> Hi Christian, >> >> mail notify for close> submitted, action is not working. is this >> notification not active by default. >> if its by default. please let me know if i can enable a mail notify for >> "submitted" action . >> >> Thanks, >> Peer >> >> >> On Thursday, July 12, 2012 2:26:56 AM UTC+5:30, Christian Hammond wrote: >>> >>> Right, it's only on publish, reviews, and replies. We're told we're too >>> noisy as it is, so doing it on drafts would probably not be in our best >>> interest ;) Also, it's just not information most users would care about. >>> >>> Christian >>> >>> -- >>> Christian Hammond - chi...@chipx86.com >>> Review Board - http://www.reviewboard.org >>> VMware, Inc. - http://www.vmware.com >>> >>> >>> On Wed, Jul 11, 2012 at 1:45 PM, superakuma <hwo...@gmail.com> wrote: >>> >>>> Christian, Email works now. We use zimbra for mail and it allows >>>> relays. Have also configured exim locally and did a telnet localhost 25 to >>>> test it. It works so I set this: >>>> Mail Server: localhost >>>> port: 25 >>>> No username and password >>>> >>>> After I "publish" a review, I do see an email. I was hoping that I get >>>> email notifications after I create a draft review via post-review but it >>>> seems like emails are only sent when you make a "publish" action. >>>> >>>> Thanks, >>>> Howard >>>> >>>> On Wednesday, July 11, 2012 11:28:57 AM UTC-7, Christian Hammond wrote: >>>>> >>>>> We show when there's an error, but not when a mail was sent. >>>>> >>>>> Can you describe your setup more? >>>>> >>>>> What SMTP server are you using, and is it on the same machine? >>>>> >>>>> What action are you performing where you expect e-mails to be sent? >>>>> >>>>> Are the recipients on mailing lists, or individuals? Gmail/Yahoo/etc, >>>>> or company e-mail? >>>>> >>>>> Christian >>>>> >>>>> -- >>>>> Christian Hammond - chi...@chipx86.com >>>>> Review Board - http://www.reviewboard.org >>>>> VMware, Inc. - http://www.vmware.com >>>>> >>>>> >>>>> On Wed, Jul 11, 2012 at 9:45 AM, superakuma <hwo...@gmail.com> wrote: >>>>> >>>>>> Thanks for the quick response. I don't see anything going to our mail >>>>>> server and nothing in the RB log. Is there a way to see something in the >>>>>> log that shows it tried to send the emails? Some debugging message would >>>>>> help. >>>>>> >>>>>> Thanks, >>>>>> Howard >>>>>> >>>>>> >>>>>> On Tuesday, July 10, 2012 10:46:49 PM UTC-7, Christian Hammond wrote: >>>>>>> >>>>>>> Hi Howard, >>>>>>> >>>>>>> I'm not aware of any bug. Plenty of people are using 1.6.9 with mail >>>>>>> servers, including us. Did you check the Review Board log or the mail >>>>>>> server log? Might be worth seeing what the mail server says. >>>>>>> >>>>>>> Christian >>>>>>> >>>>>>> -- >>>>>>> Christian Hammond - chi...@chipx86.com >>>>>>> Review Board - http://www.reviewboard.org >>>>>>> VMware, Inc. - http://www.vmware.com >>>>>>> >>>>>>> >>>>>>> On Tue, Jul 10, 2012 at 10:29 PM, superakuma <hwo...@gmail.com>wrote: >>>>>>> >>>>>>>> I have RB 1.6.9 installed and got everything working but the email >>>>>>>> setup. I input a valid SMTP server and even tried it out using telnet >>>>>>>> test. >>>>>>>> That works. I checked the log and nothing shows up. Is there anyway >>>>>>>> for me >>>>>>>> to debug this to see what's wrong or there is a bug in this release? >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Howard >>>>>>>> >>>>>>>> -- >>>>>>>> Want to help the Review Board project? Donate today at >>>>>>>> http://www.reviewboard.org/**don****ate/<http://www.reviewboard.org/donate/> >>>>>>>> Happy user? Let us know at >>>>>>>> http://www.reviewboard.org/**use****rs/<http://www.reviewboard.org/users/> >>>>>>>> -~----------~----~----~----~--******----~----~------~--~--- >>>>>>>> To unsubscribe from this group, send email to reviewboard...@** >>>>>>>> google****groups.com >>>>>>>> For more options, visit this group at http://groups.google.com/** >>>>>>>> group****/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en> >>>>>>> >>>>>>> >>>>>>> >>>>>> -- >>>>>> Want to help the Review Board project? Donate today at >>>>>> http://www.reviewboard.org/**don**ate/<http://www.reviewboard.org/donate/> >>>>>> Happy user? Let us know at >>>>>> http://www.reviewboard.org/**use**rs/<http://www.reviewboard.org/users/> >>>>>> -~----------~----~----~----~--****----~----~------~--~--- >>>>>> To unsubscribe from this group, send email to reviewboard...@**google >>>>>> **groups.com >>>>>> For more options, visit this group at http://groups.google.com/** >>>>>> group**/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en> >>>>>> >>>>> >>>>> >>>> -- >>>> Want to help the Review Board project? Donate today at >>>> http://www.reviewboard.org/**donate/<http://www.reviewboard.org/donate/> >>>> Happy user? Let us know at >>>> http://www.reviewboard.org/**users/<http://www.reviewboard.org/users/> >>>> -~----------~----~----~----~--**----~----~------~--~--- >>>> To unsubscribe from this group, send email to reviewboard...@** >>>> googlegroups.com >>>> For more options, visit this group at http://groups.google.com/** >>>> group/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en> >>>> >>> >>> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> reviewboard...@googlegroups.com <javascript:> >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> >> >> >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> reviewboard...@googlegroups.com <javascript:> >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> >> >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> reviewboard...@googlegroups.com <javascript:> >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> >> >> > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
