Alexey,

Responses inline

On Tue, Jan 14, 2014 at 6:14 PM, Alexey Neyman <alexey.ney...@gmail.com>wrote:

> 1. When I tried to invoke post-review (yes, I still have to use that - see
> the second question as to "why") on a working copy which had some files
> renamed, it printed the following message:
>
> One or more files in your changeset has history scheduled with commit.
> Please try again with '--svn-show-copies-as-adds=y/n'
>
> However, post-review does not support this option:
>
> $ post-review --svn-show-copies-as-adds=n
> The "post-review" tool is deprecated in favor of the"rbt" suite of
> commands. post-review will go away in RBTools 0.6.x.
> Usage: post-review [-pond] [-r review_id] [changenum]
> post-review: error: no such option: --svn-show-copies-as-adds
>
>
This is an oversight. A third-party patch introduced the
--svn-show-copies-as-adds in the backend, but didn't include the option in
post-review. We'll get a patch in to fix it for 0.5.5, and I've attached
that patch here if you'd like to try it out.



> 2. As to using post-review instead of 'rbt post': in our set up,
> post-review works but 'rbt post' doesn't. The reason is that our SVN
> repository is configured in RB with file:// protocol, while developers
> access it using svn:// protocol. The reasons for this configuration is to
> reduce the load on the server (since RB is running on the same machine, why
> should it go over the network when it can access repository directly). This
> also allows RB to see the repository without a dedicated RB user.
>

We're going to be improving the way that rbt post (and post-review) match
SVN repositories on the server. 0.5.5 will include this change:
https://reviews.reviewboard.org/r/5248/ , which will let you pass in the
repository name through the --repository-url flag (or associated REPOSITORY
config key). For the 0.6 release, we'll be separating this out into a
--repository setting.

-David

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
diff --git a/rbtools/postreview.py b/rbtools/postreview.py
index b75ab80..9a281d9 100755
--- a/rbtools/postreview.py
+++ b/rbtools/postreview.py
@@ -1145,6 +1145,12 @@ def parse_options(args):
                       default=get_config_value(configs, 'P4_PASSWD'),
                       help="the Perforce password or ticket of the user "
                            "in the P4USER environment variable")
+    parser.add_option('--svn-show-copies-as-adds',
+                      dest='svn_show_copies_as_adds',
+                      metavar='y/n',
+                      default=None,
+                      help="don't show copied or moved files with their "
+                           "source")
     parser.add_option('--svn-changelist', dest='svn_changelist', default=None,
                       help='generate the diff for review based on a local SVN '
                            'changelist')

Reply via email to