Lee, Glad it's working! We'll get the fix out in an official release soon.
-David On Mon, May 26, 2014 at 1:12 AM, Lee Laborczfalvi <[email protected]>wrote: > You're right I screwed up. > > Thanks for your support - this is working now! Brilliant product all > around. > > Thanks > Lee > > > On Monday, May 26, 2014 10:04:39 AM UTC+2, David Trowbridge wrote: > >> Probably there was some error with your change. Check the reviewboard or >> apache logs. >> >> -David >> >> >> On Mon, May 26, 2014 at 1:02 AM, Lee Laborczfalvi <[email protected]>wrote: >> >>> I did that, restarted apache now it says review board is taking a nap >>> >>> There are several possible reasons: >>> >>> - We're updating it. >>> - You're trying to look at a really huge diff without collapsing, >>> and it timed out (try viewing another diff and going back to collapsed >>> changes; we're working on fixing this). >>> - Our lazy good-for-nothing oompa-loompas stopped pedalling. >>> >>> It'll be back soon. >>> >>> On Monday, May 26, 2014 9:46:54 AM UTC+2, David Trowbridge wrote: >>> >>>> If you want to make a change to your local installation, open >>>> reviewboard/diffviewer/managers.py and find _normalize_diff_filename. >>>> Change that method to just always 'return filename' >>>> >>>> -David >>>> >>>> >>>> On Mon, May 26, 2014 at 12:44 AM, Lee Laborczfalvi >>>> <[email protected]>wrote: >>>> >>>>> :((((( >>>>> >>>>> When is that out? >>>>> >>>>> Here's the bug. When I generate the diff using rbt post -d <changenum> >>>>> I see this >>>>> >>>>> >>> Python 2.7.5 (default, Mar 9 2014, 22:15:05) >>>>> [GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)] >>>>> >>> Running on Darwin-13.2.0-x86_64-i386-64bit >>>>> >>> Home = /Users/xxxxxx >>>>> >>> Current directory = /Volumes/perforce/mobilemail >>>>> >>> Checking for a Perforce repository... >>>>> >>> Running: p4 -c clientname -p servername:portnumber -P password info >>>>> >>> Running: diff --version >>>>> >>> repository info: Path: ['servername:portname', >>>>> 'servername:portname', 'servername:portname', 'servername:portname'], Base >>>>> path: None, Supports changesets: True >>>>> >>> Making HTTP GET request to http://mobile-dev.eng.citrite. >>>>> net/reviews/api/ >>>>> Generating diff for pending changeset 275128 >>>>> >>> Processing edit of //serverpath/filename.m >>>>> >>> Writing "//serverpath/filename.m#317" to "/var/folders/df/4f6_ >>>>> 7j7n0zn565w96z2cb9dr0000gn/T/tmp3mltFl" >>>>> >>> Running: p4 -c clientname -p servername:portname -P password print >>>>> -o /var/folders/df/4f6_7j7n0zn565w96z2cb9dr0000gn/T/tmp3mltFl -q >>>>> //servername/filename.m#317 >>>>> >>> Running: diff -urNp /var/folders/df/4f6_7j7n0zn565 >>>>> w96z2cb9dr0000gn/T/tmp3mltFl /clientfilepath/filename.m >>>>> >>> Command exited with rc 1: ['diff', '-urNp', '/var/folders/df/4f6_ >>>>> 7j7n0zn565w96z2cb9dr0000gn/T/tmp3mltFl', >>>>> '/Volumes/perforce/mobilemail/iOS/main/ExchangeMail/activesy >>>>> nc/ASController.m'] >>>>> --- /var/folders/df/4f6_7j7n0zn565w96z2cb9dr0000gn/T/tmp3mltFl >>>>> 2014-05-26 09:36:57.000000000 +0200 >>>>> +++ /clientpath/filename.m 2014-05-26 09:36:02.000000000 +0200 >>>>> @@ -1627,7 +1627,7 @@ >>>>> } >>>>> else >>>>> { >>>>> - // removed line >>>>> + // added line >>>>> } >>>>> --- >>>>> >>> Making HTTP GET request to http://mobile-dev.eng.citrite. >>>>> net/reviews/api/review-requests/ >>>>> >>> Making HTTP POST request to http://mobile-dev.eng.citrite. >>>>> net/reviews/api/review-requests/ >>>>> >>> Making HTTP GET request to http://mobile-dev.eng.citrite. >>>>> net/reviews/api/review-requests/4282/diffs/ >>>>> >>> Making HTTP POST request to http://mobile-dev.eng.citrite. >>>>> net/reviews/api/review-requests/4282/diffs/ >>>>> >>> Making HTTP GET request to http://mobile-dev.eng.citrite. >>>>> net/reviews/api/review-requests/4282/draft/ >>>>> >>> Making HTTP PUT request to http://mobile-dev.eng.citrite. >>>>> net/reviews/api/review-requests/4282/draft/ >>>>> Review request #4282 posted. >>>>> >>>>> http://mobile-dev.eng.citrite.net/reviews/r/4282/ >>>>> http://mobile-dev.eng.citrite.net/reviews/r/4282/diff/ >>>>> >>>>> So note that it's posting the server path as // >>>>> >>>>> But when I look on the server at the path to the changed file it shows >>>>> this: >>>>> >>>>> /serverpath/filename.m >>>>> >>>>> So the leading "/" has been dropped. >>>>> >>>>> I think that's the bug - is there anything I can modify on my >>>>> installation to just make this work? >>>>> >>>>> Thanks >>>>> lee >>>>> >>>>> On Monday, May 26, 2014 9:25:29 AM UTC+2, David Trowbridge wrote: >>>>> >>>>>> Lee, >>>>>> >>>>>> It looks like this is a regression in 2.0. We'll get a fix in for >>>>>> 2.0.1 (which is coming out very soon). >>>>>> >>>>>> -David >>>>>> >>>>>> >>>>>> On Mon, May 26, 2014 at 12:19 AM, Lee Laborczfalvi <[email protected] >>>>>> > wrote: >>>>>> >>>>>>> More information on this. >>>>>>> >>>>>>> >>>>>>> When I look at an OLD request (i.e. one created on 1.7) I can see >>>>>>> this in the source of the diff viewer page: >>>>>>> >>>>>>> model: new RB.DiffViewerPageModel({"num_diffs": 1, "files": >>>>>>> [{"comment_counts": [], "index": 0, "deleted": false, "dest_revision": >>>>>>> "New Change", "id": 25472, "filediff": {"id": 25472, "revision": 1}, >>>>>>> "binary": false, "depot_filename": >>>>>>> "//icaclient/develop/MobileMail/iOS/main/ExchangeMail/AppDelegate.m", >>>>>>> "dest_filename": >>>>>>> "//icaclient/develop/MobileMail/iOS/main/ExchangeMail/AppDelegate.m", >>>>>>> "newfile": false, "revision": "Revision 334"}, {"comment_counts": [], >>>>>>> "index": 1, "deleted": false, "dest_revision": "New Change", "id": >>>>>>> 25473, "filediff": {"id": 25473, "revision": 1}, "binary": false, >>>>>>> "depot_filename": >>>>>>> "//icaclient/develop/MobileMail/iOS/main/ExchangeMail/MigrationManager.m", >>>>>>> "dest_filename": >>>>>>> "//icaclient/develop/MobileMail/iOS/main/ExchangeMail/MigrationManager.m", >>>>>>> "newfile": false, "revision": "Revision 17"}], "pagination": >>>>>>> {"has_next": false, "page_numbers": [1], "current_page": 1, >>>>>>> "has_previous": false, "is_paginated": false, "pages": 1}, >>>>>>> "comments_hint": {"diffsets_with_comments": [], "has_other_comments": >>>>>>> false, "interdiffs_with_comments": []}, "revision": >>>>>>> {"interdiff_revision": null, "is_draft_interdiff": null, >>>>>>> "latest_revision": 1, "is_draft_diff": null, "is_interdiff": false, >>>>>>> "revision": 1}}, >>>>>>> >>>>>>> >>>>>>> But when I look at the NEW request - check out how the >>>>>>> depot_filename and dest_filename are now no longer preceded by a // >>>>>>> (double slash) but rather a / (single slash). This is what I believe is >>>>>>> causing the problem since it's not interpreting the file path as a >>>>>>> server >>>>>>> path! >>>>>>> >>>>>>> model: new RB.DiffViewerPageModel({"num_diffs": 3, "files": >>>>>>> [{"comment_counts": [], "index": 0, "deleted": false, "dest_revision": >>>>>>> "New Change", "id": 25555, "filediff": {"id": 25555, "revision": 3}, >>>>>>> "binary": false, "depot_filename": >>>>>>> "/icaclient/develop/MobileMail/iOS/main/ExchangeMail/activesync/ASController.m", >>>>>>> "dest_filename": >>>>>>> "/icaclient/develop/MobileMail/iOS/main/ExchangeMail/activesync/ASController.m", >>>>>>> "newfile": false, "revision": "Revision 317"}], "pagination": >>>>>>> {"has_next": false, "page_numbers": [1], "current_page": 1, >>>>>>> "has_previous": false, "is_paginated": false, "pages": 1}, >>>>>>> "comments_hint": {"diffsets_with_comments": [], "has_other_comments": >>>>>>> false, "interdiffs_with_comments": []}, "revision": >>>>>>> {"interdiff_revision": null, "is_draft_interdiff": null, >>>>>>> "latest_revision": 3, "is_draft_diff": null, "is_interdiff": false, >>>>>>> "revision": 3}}, >>>>>>> >>>>>>> >>>>>>> How can this be fixed??? >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Monday, May 26, 2014 8:46:06 AM UTC+2, Lee Laborczfalvi wrote: >>>>>>>> >>>>>>>> I'm facing a pretty bad problem (bad because it's a Monday) where a >>>>>>>> RB upgrade has broken all our perforce repositories. >>>>>>>> >>>>>>>> The error that I'm getting is this: >>>>>>>> >>>>>>>> There was an error displaying this diff. >>>>>>>> >>>>>>>> [P4#run] Errors during command execution( "p4 print -q >>>>>>>> /xxxxx/develop/MobileMail/iOS/main/ExchangeMail/xxxxx/xxxxx.m#317" >>>>>>>> ) [Error]: "/client/develop/MobileMail/iOS/main/ExchangeMail/xxxx/ >>>>>>>> xxxxx.m - must create client 'mobile-dev' to access local files." >>>>>>>> >>>>>>>> This may be a bug in the software, a temporary outage, or an issue >>>>>>>> with the format of your diff. >>>>>>>> >>>>>>>> Please try again, and if you still have trouble, contact >>>>>>>> support<http://mobile-dev.eng.citrite.net/reviews/support/> >>>>>>>> . >>>>>>>> >>>>>>>> Now mobile-dev is part of the review board URL that we host >>>>>>>> internally. I have got a username and password entered for the perforce >>>>>>>> configuration page that is a valid perforce user on the server. It >>>>>>>> appears >>>>>>>> that the command line is not taking all of the perforce parameters for >>>>>>>> the >>>>>>>> server, since I'd expect it to be able to talk to the server. >>>>>>>> >>>>>>>> Also - what does "to access local files" mean? Is a change in >>>>>>>> permissions from the 1.7 release required? >>>>>>>> >>>>>>>> Thanks >>>>>>>> Lee >>>>>>>> >>>>>>> -- >>>>>>> Get the Review Board Power Pack at http://www.reviewboard.org/pow >>>>>>> erpack/ >>>>>>> --- >>>>>>> Sign up for Review Board hosting at RBCommons: >>>>>>> https://rbcommons.com/ >>>>>>> --- >>>>>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>>>>> --- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "reviewboard" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to [email protected]. >>>>>>> >>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>> >>>>>> >>>>>> -- >>>>> Get the Review Board Power Pack at http://www.reviewboard.org/pow >>>>> erpack/ >>>>> --- >>>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >>>>> --- >>>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "reviewboard" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- >>> Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ >>> --- >>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >>> --- >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
