Hi Christian,

Thank you for a quick answer.
We are really looking forward to obtain new ReviewBoard release with 
enhanced diff algorithms. :-)

Eugene

среда, 25 мая 2016 г., 22:12:08 UTC+3 пользователь Christian Hammond 
написал:
>
> Hi Eugene,
>
> This isn't actually a bug. Rather, it's just how the Myers Diff Algorithm 
> (that used by us, GNU diff, and many other tools) chose to represent this 
> particular change. It decided that there was just enough similarity, given 
> the lines and surrounding content, to mark it as a replaced line instead of 
> a delete and remove. Each thing on the left was replaced by a thing on the 
> right, as far as it sees.
>
> Diff algorithms don't *always* generate the best diff for a human's 
> consumption, but usually it's pretty close, or close enough. There are 
> other algorithms that sometimes help better in some cases like these, and 
> we're brainstorming about how best to implement those as alternatives in 
> the future.
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>
> On Wed, May 25, 2016 at 2:21 AM, <eugene....@gmail.com <javascript:>> 
> wrote:
>
>> Hi!
>>
>> I have ReviewBoard 2.5.3 installed via Bitnami installer "Review Board 
>> 2.5.4-0.exe" on Windows Server 2008 R2.
>>
>> I do the following:
>>
>>
>>    1. Commit new file test.cs to SVN repository (revision/file extension 
>>    142004 in attach). 
>>    2. Commit changed file test.cs to SVN (revision/file extension 142005 
>>    in attach). 
>>    3. Create diff for the latest commit ("svn diff -c 142005 > 
>>    diff-142005"). 
>>    4. Create review request based on prepared diff ("rbt post 
>>    --diff-file diff-142005"). 
>>    5. Open created review request in diff tab (Chrome/Firefox on Windows 
>>    7). 
>>
>> I expect that line with function "public byte[] Buffer(...) {...}" should be 
>> highlighted as new code block (green).
>> Instead *new line is highlighted as changed lines* (yellow).
>>
>>
>>
>> Both revisions if file test.cs and generated diff are attached.
>>
>> Any ideas how to fix this?
>>
>> -- Eugene
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to