Hi, Thanks. I'd definitely like to get proper support for self-signed certs going in Review Board. The reason it wasn't there before is that it's been only somewhat recently that Python's HTTPS support even cared about proper certificate verification. We didn't used to have to worry about it. We have some support for handling self-signed certs for Subversion (which uses its own cert verification), so getting this set up for other repos would be good.
Patches welcome, of course :) And I'd be happy to show how that code works today, and give a sense of what would need to be done.. pBut I'm adding a task for us internally so we can track it. Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> On Thu, Jul 7, 2016 at 10:30 AM, <[email protected]> wrote: > This is a temporary hack but I'm disabling all SSL cert validation by > doing: > > ssl._create_default_https_context = ssl._create_unverified_context > > inside the gitlab.py (doesn't really matter where we do this i guess). > > I'm on the latest RB 2.5.6.1 version using Python 2.7.10. > > Thanks! > > On Wednesday, July 6, 2016 at 11:37:31 PM UTC-7, Christian Hammond wrote: >> >> Hi, >> >> Can you show me the code you've used to skip over it, and let me know the >> version of Python you're using? >> >> Also, what version of Review Board? >> >> Christian >> >> -- >> Christian Hammond >> President/CEO of Beanbag <https://www.beanbaginc.com/> >> Makers of Review Board <https://www.reviewboard.org/> >> >> On Wed, Jul 6, 2016 at 11:06 PM, <[email protected]> wrote: >> >>> Hello, >>> >>> I switched to using the gitlab integration on ReviewBoard. Previously, I >>> was using a custom git repository setup on the local machine where I was >>> running a crontab to peridically update the local repos. >>> >>> ReviewBoard/Python was not happy with the self-signed cert. For now, >>> I've added some code in the reviewboard source to skip the ssl >>> verification. Wondering if there's a better way to configure this in >>> ReviewBoard so that when I upgrade RB, I won't have to keep disabling the >>> SSL verification. >>> >>> Thanks! >>> >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
