I think we'll need a copy of the diff in order to diagnose this,
unfortunately.

Christian

-- 
Christian Hammond
President/CEO of Beanbag <https://www.beanbaginc.com/>
Makers of Review Board <https://www.reviewboard.org/>

On Thu, Jan 26, 2017 at 4:19 AM, Rodolfo Gomes Dias <
[email protected]> wrote:

> Thanks for your help.
>
> But, the error is still happening, it just moved to another place.
>
> Here is the log:
>
> 2017-01-26 10:11:44,559 - ERROR -  - Unable to update new review request
> from commit ID 303885e3c0b10c255a9c2d8428c6b624150175b7: 'ascii' codec
> can't decode byte 0xc7 in position 1362: ordinal not in range(128)
> Traceback (most recent call last):
>   File "C:\Bitnami\reviewboard-2.5.7-2\apps\reviewboard\htdocs\Lib\
> site-packages\ReviewBoard-2.5.7-py2.7.egg\reviewboard\reviews\managers.py",
> line 157, in create
>     draft.update_from_commit_id(commit_id)
>   File "C:\Bitnami\reviewboard-2.5.7-2\apps\reviewboard\htdocs\Lib\
> site-packages\ReviewBoard-2.5.7-py2.7.egg\reviewboard\
> reviews\models\base_review_request_details.py", line 221, in
> update_from_commit_id
>     self.update_from_committed_change(commit_id)
>   File "C:\Bitnami\reviewboard-2.5.7-2\apps\reviewboard\htdocs\Lib\
> site-packages\ReviewBoard-2.5.7-py2.7.egg\reviewboard\
> reviews\models\base_review_request_details.py", line 278, in
> update_from_committed_change
>     diff_file_contents=commit.diff.encode('utf-8'),
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc7 in position 1362:
> ordinal not in range(128)
>
>
>
>
> On Tuesday, January 24, 2017 at 7:20:17 PM UTC-2, Christian Hammond wrote:
>>
>> Hi,
>>
>> We have a fix coming for this in 2.5.8, which will be this week. Bitnami
>> should follow. If you feel comfortable applying patches by hand, you can
>> try the attached patch (must apply in C:\Bitnami\reviewboard-2.5.7-
>> 2\apps\reviewboard\htdocs\Lib\site-packages\ReviewBoard-2.5.7-py2.7.egg).
>>
>> Christian
>>
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag <https://www.beanbaginc.com/>
>> Makers of Review Board <https://www.reviewboard.org/>
>>
>> On Tue, Jan 24, 2017 at 11:57 AM, Rodolfo Gomes Dias <
>> [email protected]> wrote:
>>
>>> I have removed all non-ascii characters in my files and the diff is
>>> correctly working. Any advice about what should I do now???
>>>
>>>
>>> On Tuesday, January 24, 2017 at 8:46:30 AM UTC-2, Rodolfo Gomes Dias
>>> wrote:
>>>>
>>>> Here it is the Review Board log right after my 'new review' error.
>>>> The error is described in line 2. But in my opinion it is software
>>>> flaw, the code I am trying to review was used in a lot of tools without any
>>>> error.
>>>> Can you help me to find out what exactly is the error? What I need to
>>>> do in my files to correctly use them with Review Board?
>>>>
>>>> Thanks.
>>>>
>>>>
>>>>
>>>> 2017-01-24 08:40:53,651 - INFO -  - Reloading logging settings
>>>> *2017-01-24 08:41:50,977 - ERROR -  - Unable to update new review
>>>> request from commit ID cf431a4ee982169a36832b60670a126dac67d764: 'ascii'
>>>> codec can't decode byte 0xc7 in position 472318: ordinal not in range(128)*
>>>> Traceback (most recent call last):
>>>>   File "C:\Bitnami\reviewboard-2.5.7-2\apps\reviewboard\htdocs\Lib\
>>>> site-packages\ReviewBoard-2.5.7-py2.7.egg\reviewboard\reviews\managers.py",
>>>> line 157, in create
>>>>     draft.update_from_commit_id(commit_id)
>>>>   File "C:\Bitnami\reviewboard-2.5.7-2\apps\reviewboard\htdocs\Lib\
>>>> site-packages\ReviewBoard-2.5.7-py2.7.egg\reviewboard\review
>>>> s\models\base_review_request_details.py", line 221, in
>>>> update_from_commit_id
>>>>     self.update_from_committed_change(commit_id)
>>>>   File "C:\Bitnami\reviewboard-2.5.7-2\apps\reviewboard\htdocs\Lib\
>>>> site-packages\ReviewBoard-2.5.7-py2.7.egg\reviewboard\review
>>>> s\models\base_review_request_details.py", line 265, in
>>>> update_from_committed_change
>>>>     commit = self.repository.get_change(commit_id)
>>>>   File "C:\Bitnami\reviewboard-2.5.7-2\apps\reviewboard\htdocs\Lib\
>>>> site-packages\ReviewBoard-2.5.7-py2.7.egg\reviewboard\scmtools\models.py",
>>>> line 450, in get_change
>>>>     return hosting_service.get_change(self, revision)
>>>>   File "C:\Bitnami\reviewboard-2.5.7-2\apps\reviewboard\htdocs\Lib\
>>>> site-packages\ReviewBoard-2.5.7-py2.7.egg\reviewboard\hostingsvcs\bitbucket.py",
>>>> line 333, in get_change
>>>>     if not diff.endswith('\n'):
>>>> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc7 in position
>>>> 472318: ordinal not in range(128)
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Tuesday, January 24, 2017 at 8:33:24 AM UTC-2, Rodolfo Gomes Dias
>>>> wrote:
>>>>>
>>>>> I am using Review Board 2.5.7 installed as a Bitname Stack.
>>>>>
>>>>> There are no errors related to the issue in apache error.log.
>>>>>
>>>>>
>>>>>
>>>>> On Monday, January 23, 2017 at 7:06:32 PM UTC-2, David Trowbridge
>>>>> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> A couple questions:
>>>>>>
>>>>>> - What version control system/hosting service is this repository
>>>>>> using?
>>>>>> - Can you go through this process and then look in the Review Board
>>>>>> and apache logs to see if there are any errors?
>>>>>>
>>>>>> -David
>>>>>>
>>>>>> On Mon, Jan 23, 2017 at 1:04 PM Rodolfo Gomes Dias <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> In some situations when I create a new review its content is empty
>>>>>>> as no change has been made on the commit. I have recently installed 
>>>>>>> Review
>>>>>>> Board in another computer running as my server. And right now I am
>>>>>>> performing some tests on my own computer to decide whether the tool is
>>>>>>> worth or not.
>>>>>>>
>>>>>>> Here are the steps:
>>>>>>>
>>>>>>> 1. Commit of files in mybranch using SourceTree;
>>>>>>> 2. On the browser *Dashboard *> *New Review Request > Create from
>>>>>>> an existing commit on*. Select mybranch and choose the commit from
>>>>>>> the last step;
>>>>>>> 3. At this point the message *Loading... *is exhibited for some
>>>>>>> seconds
>>>>>>> 4. When the review configuration appears, the screen with Summary,
>>>>>>> Description, Testing Done, etc, it appears as no diff was found on the
>>>>>>> selected commit. There isn't  a tab called Diff, and the files doesn't
>>>>>>> appear on the bottom of the page.
>>>>>>>
>>>>>>> I have tried a lot of different commits, using few files, a lot of
>>>>>>> files. I have tested different file encondings. But I haven't found a
>>>>>>> pattern yet.
>>>>>>>
>>>>>>> I tried to reproduce the error changing the content of files,
>>>>>>> commiting only small changes in files already commited, and in some
>>>>>>> situations the error happened and on others no.
>>>>>>>
>>>>>>> Is it a bug? Some wrong configuration on my server? A feature! Any
>>>>>>> help would be great.
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>> --
>>>>>>> Supercharge your Review Board with Power Pack:
>>>>>>> https://www.reviewboard.org/powerpack/
>>>>>>> Want us to host Review Board for you? Check out RBCommons:
>>>>>>> https://rbcommons.com/
>>>>>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>>>>>> ---
>>>>>>> You received this message because you are subscribed to the Google
>>>>>>> Groups "reviewboard" group.
>>>>>>> To unsubscribe from this group and stop receiving emails from it,
>>>>>>> send an email to [email protected].
>>>>>>> For more options, visit https://groups.google.com/d/optout.
>>>>>>>
>>>>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to [email protected].
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to