Hi all,

we are trying to generate a review request for a public Git repository:

https://github.com/DaedalicEntertainment/qt-coding-conventions

Our first try was to setup the repository in Reviewboard 2.5.11 as follows:

   - Name: Qt Coding Conventions
   - Hosting Service: GitHub
   - Account username: DaedalicEntertainment
   - Account password: ***
   - Repository type: Git
   - Repository plan: Public
   - Repository name: qt-coding-conventions
   - Use hosting service's bug tracker: true
   - Publicly accessible: true

This yields the following error:

*Unknown error when linking the account: class HTTPBasicAuthHandler has no 
attribute 'capitalize'. The details of the failure are in the Review Board 
log file.*

Assuming that the GitHub API might have changed, we changed the 
configuration as follows:

   - Name: Qt Coding Conventions
   - Hosting Service: (None - Custom Repository)
   - Repository type: Git
   - Path: 
   https://github.com/DaedalicEntertainment/qt-coding-conventions.git
   - Raw file URL mask: 
   
https://raw.githubusercontent.com/DaedalicEntertainment/qt-coding-conventions/<revision>/<filename>
   - Username: DaedalicEntertainment
   - Password: ***
   - Bug tracker type: (Custom Bug Tracker)
   - Bug tracker URL: http://issuetracker.daedalic.de/view.php?id=%s

Then, we've locally switched the branch to 
https://github.com/DaedalicEntertainment/qt-coding-conventions/tree/hotfix/auto-pointer-symbol-inconsistency
 
and opened a command-line window for using rbt. After successful login, 
we've created a .reviewboardrc file with the following contents:

REVIEWBOARD_URL = "http://tegan/reviewboard";
REPOSITORY = "Qt Coding Conventions"
REPOSITORY_TYPE = "git"
TRACKING_BRANCH = "origin/master"


where tegan/reviewboard is the Reviewboard instance of our local network.

Now, posting the review request yields the following results:

E:\Projects\qt-coding-conventions>rbt post --debug
>>> RBTools 0.7.10
>>> Python 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:42:59) [MSC v.1500 
32 bit (Intel)]
>>> Running on Windows-10-10.0.14393
>>> Home = C:\Users\Daedalic\AppData\Roaming
>>> Current directory = E:\Projects\qt-coding-conventions
>>> Command line: rbt post --debug
>>> Running: tf vc help
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git config --get branch.hotfix/auto-pointer-symbol-
inconsistency.merge
>>> Running: git config --get branch.hotfix/auto-pointer-symbol-
inconsistency.remote
>>> Running: git config --get remote.origin.url
>>> repository info: Path: 
>>> https://github.com/DaedalicEntertainment/qt-coding-conventions.git, 
Base path: , Supports changesets: False
>>> Making HTTP GET request to http://tegan/reviewboard/api/
>>> Running: git rev-parse refs/heads/hotfix/auto-pointer-symbol-
inconsistency
>>> Running: git merge-base 30beb26998c1f4264ffc4d3fee7571256b54dffc origin/
master
>>> Running: git rev-parse c7a0175b5d77f66163d0142130c3b9a60455198b
>>> Running: git status --porcelain --untracked-files=no --ignore-submodules
=dirty
>>> Running: git rev-parse --git-dir
>>> Running: git version
>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff --no-color 
--full-index --ignore-submodules -M --no-ext-diff 
c7a0175b5d77f66163d0142130c3b9a60455198b..
30beb26998c1f4264ffc4d3fee7571256b54dffc
>>> Making HTTP GET request to http:
//tegan/reviewboard/api/validation/diffs/
>>> Cached response for HTTP GET http://tegan/reviewboard/api/validation/diffs/ 
expired and was modified
>>> Making HTTP POST request to http:
//tegan/reviewboard/api/validation/diffs/
>>> Got API Error 207 (HTTP code 400): The file was not found in the 
repository.
>>> Error data: {u'stat': u'fail', u'file': u'README.md', u'err': {u'msg': 
>>> u'The 
file was not found in the repository.', u'code': 207}, u'revision': u
'4f266eb44b724d3ced73f8f1069eef23a11f77fd'}
Traceback (most recent call last):
  File "C:\Program Files 
(x86)\RBTools\bin\..\Python27\Scripts\rbt-script.py", line 11, in <module>
    load_entry_point('RBTools==0.7.10', 'console_scripts', 'rbt')()
  File "C:\Program Files 
(x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\main.py"
, line 133, in main
    command.run_from_argv([RB_MAIN, command_name] + args)
  File "C:\Program Files 
(x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\__init__.py"
, line 663, in run_from_argv
    exit_code = self.main(*args) or 0
  File "C:\Program Files 
(x86)\RBTools\Python27\lib\site-packages\rbtools-0.7.10-py2.7.egg\rbtools\commands\post.py"
, line 812, in main
    (msg_prefix, e))
rbtools.commands.CommandError: Error validating diff
README.md: The file was not found in the repository. (HTTP 400, API Error 
207)


At first, the diff range looks promising: c7a0175 
<https://github.com/DaedalicEntertainment/qt-coding-conventions/commit/c7a0175b5d77f66163d0142130c3b9a60455198b>
 
is the tip of the master branch (both locally and at the origin), and 
30beb26 
<https://github.com/DaedalicEntertainment/qt-coding-conventions/commit/30beb26998c1f4264ffc4d3fee7571256b54dffc>
 
is the commit we want to review (both locally and at the origin).

However, the error message suggests that ReviewBoard tries to find the 
affected file in a commit 4f266eb44b724d3ced73f8f1069eef23a11f77fd, which 
doesn't exist anywhere.

Are we missing something here?

Warm regards,
Nick

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to