I can confirm that when updating rbstopwatch to use setExtraData() followed by a save(), it works properly. I'd need to see what your code and the data from the browser looks like to figure out what's going wrong.
Christian On Thu, Dec 14, 2017 at 12:31 PM, Christian Hammond < [email protected]> wrote: > Sorry, I realize rbstopwatch isn't using setExtraData, but rather setting > extraData manually. I'm going to toy with the code here, see if I can > reproduce the problem. > > Christian > > On Thu, Dec 14, 2017 at 12:29 PM, Christian Hammond < > [email protected]> wrote: > >> Hi, >> >> Can you show me your code that both sets this and then saves the review, >> along with what the browser is reporting being sent to and received from >> the server? (Full headers and payloads would help.) >> >> rbstopwatch was indeed broken (fix coming in RB 3.0.2), but once I fixed >> that, setExtraData did work properly, so I'm wondering if there's a change >> that's impacting your code in a more subtle way. >> >> Christian >> >> On Thu, Dec 14, 2017 at 3:00 AM, Xy Sui <[email protected]> wrote: >> >>> Hi, >>> >>> I'm getting desperate after hours' searching/trying... One of our >>> extensions doesn't work now in RVB3.0 because previous setExtraData method >>> doesn't work anymore for review model. >>> >>> In my implementation, I wrote one RB.ReviewDialogHook javascript hook >>> with one customized view. And I would like to save some data in model >>> Review's extraData field. I noticed model Review does have "setExtraData" >>> method, but it's not working... >>> >>> And it looks like the extension rbstopwatch also saves data in >>> extra_data, while the extension is broken in RVB 3.0 as well. So I couldn't >>> find one working example either. >>> >>> Could anybody help? Or anybody has one working example for extra_data >>> setting in javascript? >>> >>> Thanks. >>> >>> BR >>> oswicer >>> >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Christian Hammond >> President/CEO of Beanbag <https://www.beanbaginc.com/> >> Makers of Review Board <https://www.reviewboard.org/> >> > > > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
