Hi Teddy, We have a change we've been testing that fixes some corner cases like this. They tend to occur as a result of the interdiff algorithm's attempt at filtering out changes that aren't part of the uploaded diffs, based on metadata available in those diffs. The algorithm in 3.0.x has corner cases that tend to result at the very top or very bottom of files, as well as in some other more rare (but still seen in production) circumstances.
The new algorithm is being tested in the 4.0 work, and once we know it's stable, the plan is to backport to 3.0.x. It's a full rewrite designed to address these sorts of problems, but potentially could cause new ones, so we've been hesitant to make it available just yet. This will be in 4.0 beta 1, which we're nearing, and we'd love to get some testing on it when it's out. Christian On Tue, Apr 14, 2020 at 1:49 PM Teddy Saintvil <tedsai...@gmail.com> wrote: > Having issues with interdiffs displaying incorrectly in the diffviewer. > I've attached screen shot of what gets displayed with a reproducer below. > > > original > // top of file > > // comment > void foo(); > > // bottom of file > > diff 1 > // top of file > > // comment > #if 0 > void foo(); > #endif > > // bottom of file > > diff 2 > // top of file > #if 0 > // comment > void foo(); > #endif > > // bottom of file > > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/reviewboard/a9fe52ca-4760-4fc4-a6b2-444df40c99e3%40googlegroups.com > <https://groups.google.com/d/msgid/reviewboard/a9fe52ca-4760-4fc4-a6b2-444df40c99e3%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAE7VndkpSqUDoJwEAH%2BBQM_Gxg0y%3D2UA8%3DHwnx%2Bz9oFOU9N6bw%40mail.gmail.com.
