Teddy, If you're viewing a diff that you had previously viewed before the upgrade, it's likely that old data may still be in cache. I'd suggest restarting your memcached service, clearing your browser cache, and then trying again.
David On Tue, Mar 23, 2021 at 7:48 AM [email protected] <[email protected]> wrote: > Hello, our team recently upgraded to Reviewboard 3.0.20 and tried the > opt-in setting to enable the new interdiff v2 algorithm by setting > > *ENABLED_FEATURES = { 'diffviewer.filter_interdiffs_v2': True, }* > > the above in conf/settings_local.py as instructed in the Reviewboard > 3.0.19 release notes below. > > > https://www.reviewboard.org/news/2020/12/10/review-board-3-0-19-new-features-review-bot-api-and-more/ > > using the same files in the reproducer in my initial message displays > identical results with the issue we were facing. > > We are using perforce as our repo of choice ( not sure if that makes any > difference). > > Did I miss something in enabling this new interdiff algorithim? Was it > perhaps not available in Reviewboard 3.0.20? > > > Let us know if there is any other information we can provide to help. > > > - Teddy > > > > > > On Friday, May 22, 2020 at 5:55:56 AM UTC-4 Christian Hammond wrote: > >> I’ll look into doing an opt-in setting to enable the new behavior in an >> upcoming 3.x release. >> >> Christian >> >> >> On Fri, May 22, 2020 at 01:55 Vlad S. <[email protected]> wrote: >> >>> huh, this bug is really annoying for .cc files. >>> >>> вторник, 14 апреля 2020 г., 23:49:44 UTC+3 пользователь Teddy Saintvil >>> написал: >>> >>>> Having issues with interdiffs displaying incorrectly in the diffviewer. >>>> I've attached screen shot of what gets displayed with a reproducer below. >>>> >>>> >>>> original >>>> // top of file >>>> >>>> // comment >>>> void foo(); >>>> >>>> // bottom of file >>>> >>>> diff 1 >>>> // top of file >>>> >>>> // comment >>>> #if 0 >>>> void foo(); >>>> #endif >>>> >>>> // bottom of file >>>> >>>> diff 2 >>>> // top of file >>>> #if 0 >>>> // comment >>>> void foo(); >>>> #endif >>>> >>>> // bottom of file >>>> >>>> >>>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Review Board Community" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> >> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/reviewboard/89fbe502-675a-4cf0-84ad-4abe161fc43e%40googlegroups.com >>> <https://groups.google.com/d/msgid/reviewboard/89fbe502-675a-4cf0-84ad-4abe161fc43e%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> -- >> Christian Hammond >> President/CEO of Beanbag >> Makers of Review Board >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "Review Board Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/reviewboard/6854647d-3778-414a-83e0-63038b1c491dn%40googlegroups.com > <https://groups.google.com/d/msgid/reviewboard/6854647d-3778-414a-83e0-63038b1c491dn%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAFS3VNWA1NPjXLp7uLWfojEqCF8PyC%3DC_wD8wAbLv6PjQPsfgw%40mail.gmail.com.
