> On March 7, 2016, 10:18 p.m., Di Li wrote:
> > ambari-web/app/templates/main/host/details/host_component.hbs, line 30
> > <https://reviews.apache.org/r/44457/diff/1/?file=1283159#file1283159line30>
> >
> >     How is the service name displayed when the component name is extra 
> > long, in relation to the new divs added ?
> >     
> >     The service name should be visible so that user can navigate back to 
> > the corresponding service.
> >     
> >     What about fixing the width of the component name and trancate it with 
> > ... when it reaches the limite.
> >     
> >     For example, ExtraLongZookeeperComponentName would be dispalyed as 
> >     
> >     ExtraLongZook.../Zookeeper
> >     
> >     The ExtraLongZookeeperComponentName is still displayed on zookeeper's 
> > dashboard where user can hover over to reveal the host name, yes ?
> 
> Keta Patel wrote:
>     Hello Di,
>     I have attached a screenshot "Extra Long Service Names with Fix.tiff" on 
> the Jira which shows how extra long service names look with the current fix.
>     Yes, you are right about the entire service name being displayed on the 
> dashboard's navigation menu on the left side.
>     I am looking into how we could use "..." or flyouts for this issue.
>     Thanks!
> 
> Keta Patel wrote:
>     Hello Di,
>     I have updated the logic in the patch to use fixed number of characters 
> in the Service Name (14 characters). It displays first 11 characters followed 
> by ellipses "..." for Service Names longer than 14 characters. Length of 14 
> characters is decided keeping in mind of "Ambari Metrics" since it is the 
> longest service name in trunk.
>     I have also added tooltip (using Ember's "bindattr" with "title", as I 
> found this being used in other places of the code as well) to display the 
> entire Service Name for all components.
>     
>     I have attached a screenshot "Service names with ellipses and 
> tooltip.tiff" to show how long service names would look like with the updated 
> fix in patch-3
>     (Note: This image was taken while testing where I had used 13 characters 
> limit only)
>     
>     Please let me know if I could make further improvements.
>     Thanks!
> 
> Di Li wrote:
>     Hello Keta, 
>     
>     That's very close. Can both component name and service name be set to a 
> fixed number of chars and with flyout ? The real estate on host page is 
> limited and  need to save room for the widgets, buttons, etc.

Hello Di,
I have updated the patch with similar changes for Component names. I have taken 
19 characters as the max length (from "App Timeline Server"). For longer 
component names, only the first 16 characters are displayed followed by 
ellipses "...".
A tooltip displaying the entire component name is also added in a <span> 
surrounding the name.

Let me know if more changes are required.
Thanks!


- Keta


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44457/#review122388
-----------------------------------------------------------


On March 8, 2016, 7:26 p.m., Keta Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44457/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 7:26 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15310
>     https://issues.apache.org/jira/browse/AMBARI-15310
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Ambari UI, navigate to Hosts and click on the hostname where the service 
> is installed. The summary page displays the list of services installed.
> Observe that longer service names does not display well. The refresh icon 
> etc. spills to the next line (see attachment "Original spacing with long 
> service name").
> Also, note the indentation of the last button for Clients does not align well 
> with the buttons above it.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/styles/application.less 755dff2 
>   ambari-web/app/templates/main/host/details/host_component.hbs 60031de 
>   ambari-web/app/templates/main/host/summary.hbs 17a0b69 
> 
> Diff: https://reviews.apache.org/r/44457/diff/
> 
> 
> Testing
> -------
> 
> FIX:
> This issue is simialr to AMBARI-11670 where the spacing for each component 
> was fixed in a <div> tag.
> The fix here also uses a similar approach where every component is surrounded 
> by a <div> tag and the width is fixed for them so that the appear in their 
> respective positions regardless of the length of service names. I have also 
> adjusted the width of the left <div> component with "span8" instead of 
> "span7" and the right <div> component of the button to "span4" instead of 
> "span5" to better adjust the spacing.
> 
> TESTS:
> No tests are written for these changes as the fix involves updates in the 
> stylesheet.
> However, the changes were tested by zooming in and out and checking if the 
> icons and names were contained in their respective blocks and not overlapping 
> with other <div> blocks.
> 
> 
> The following is the result of running ambari-web tests:
> 
>   24565 tests complete (28 seconds)
>   145 tests pending
> 
> 
> File Attachments
> ----------------
> 
> AMBARI-15310 (patch-2)
>   
> https://reviews.apache.org/media/uploaded/files/2016/03/07/5ade9968-bb9d-4d61-8362-740fb24c591f__AMBARI-15310_Mar07.patch
> AMBARI-15310 (patch-3)
>   
> https://reviews.apache.org/media/uploaded/files/2016/03/08/3bb20fc6-7b52-47b3-8e08-f1325e37aedd__AMBARI-15310_Mar08.patch
> 
> 
> Thanks,
> 
> Keta Patel
> 
>

Reply via email to