----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44723/#review123198 -----------------------------------------------------------
Ship it! Ship It! - Xi Wang On March 11, 2016, 11:50 a.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44723/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 11:50 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-15394 > https://issues.apache.org/jira/browse/AMBARI-15394 > > > Repository: ambari > > > Description > ------- > > Due to case that service has the same key with its component (e.g. Pig), > App.format.role() needs a second parameter to know which it should return. > > > Diffs > ----- > > ambari-web/app/controllers/global/background_operations_controller.js > 4156e46 > > ambari-web/app/controllers/main/admin/highAvailability/hawq/activateStandby/step3_controller.js > 8a99b1e > > ambari-web/app/controllers/main/admin/highAvailability/hawq/addStandby/step4_controller.js > e468541 > > ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js > d612821 > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js > 15c0701 > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js > 404c54c > > ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js > 6562f3f > > ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step4_controller.js > dc681ea > ambari-web/app/controllers/main/admin/kerberos/step3_controller.js b51f8ec > ambari-web/app/controllers/main/admin/security/add/step3.js 0e66cc5 > ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js > e956a9e > ambari-web/app/controllers/main/host/details.js 96d6e12 > ambari-web/app/controllers/main/service/add_controller.js f85ce3f > ambari-web/app/controllers/main/service/manage_config_groups_controller.js > c208df7 > ambari-web/app/controllers/main/service/reassign/step4_controller.js > abca7d9 > ambari-web/app/controllers/main/service/reassign/step6_controller.js > 67fa99e > ambari-web/app/controllers/wizard.js aa82234 > ambari-web/app/controllers/wizard/slave_component_groups_controller.js > 584fdf2 > ambari-web/app/controllers/wizard/step10_controller.js 874a864 > ambari-web/app/controllers/wizard/step6_controller.js ea005eb > ambari-web/app/controllers/wizard/step8_controller.js 747bf83 > ambari-web/app/controllers/wizard/step9_controller.js c3a0e67 > ambari-web/app/mappers/service_metrics_mapper.js cd341b2 > ambari-web/app/mixins/common/configs/configs_saver.js ecc3466 > ambari-web/app/mixins/main/host/details/host_components/decommissionable.js > b99cea7 > ambari-web/app/mixins/main/service/configs/config_overridable.js 6280df1 > ambari-web/app/mixins/wizard/assign_master_components.js 6fcf335 > ambari-web/app/mixins/wizard/wizardProgressPageController.js 4f32075 > ambari-web/app/models/alerts/alert_definition.js 18b7dc6 > ambari-web/app/models/configs/service_config_version.js 22620c1 > ambari-web/app/models/root_service.js af42a1f > ambari-web/app/models/service.js d415817 > ambari-web/app/models/stack_service.js 1580b67 > ambari-web/app/utils/batch_scheduled_requests.js 3e57a3b > ambari-web/app/utils/helper.js 31e8955 > ambari-web/app/utils/host_progress_popup.js 7ba3618 > ambari-web/app/views/common/rolling_restart_view.js d84f9c6 > ambari-web/app/views/main/admin/stack_upgrade/failed_hosts_modal_view.js > 2dbcb75 > ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js > 8cfac65 > ambari-web/app/views/main/charts/heatmap/heatmap_host.js 2abee46 > ambari-web/app/views/main/host.js f821a90 > ambari-web/app/views/main/host/hosts_table_menu_view.js 6b36534 > ambari-web/app/views/main/host/summary.js 745691f > ambari-web/app/views/main/service/info/configs.js 45faeaa > ambari-web/app/views/main/service/info/summary.js d019a91 > ambari-web/app/views/main/service/item.js 816db4f > ambari-web/app/views/main/service/reassign/step4_view.js 132c29e > ambari-web/app/views/main/service/reassign/step6_view.js 9c718e9 > ambari-web/app/views/wizard/step6_view.js e038d18 > ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js fb61a02 > ambari-web/test/controllers/main/service/add_controller_test.js 68a6cf7 > ambari-web/test/controllers/wizard/step4_test.js bd38bc3 > ambari-web/test/utils/helper_test.js d0a469f > > Diff: https://reviews.apache.org/r/44723/diff/ > > > Testing > ------- > > Modified unit test. Local ambari-web test passed. > 10466 tests complete (10 seconds) > 121 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
