----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45518/#review126290 -----------------------------------------------------------
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricReadHelper.java (line 75) <https://reviews.apache.org/r/45518/#comment189245> sum divided by count is an average value, but not sum? - Dmytro Sen On Март 31, 2016, 1:36 д.п., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45518/ > ----------------------------------------------------------- > > (Updated Март 31, 2016, 1:36 д.п.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-15638 > https://issues.apache.org/jira/browse/AMBARI-15638 > > > Repository: ambari > > > Description > ------- > > Sum Calculation is incorrect when the time range is more than 2 hrs. > This issue affects all metrics that are queried with the "sum" aggregator > (with or without hostname being specified) for more than a 2hr time-range. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricReadHelper.java > 846ae92 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java > e67a5b8 > > Diff: https://reviews.apache.org/r/45518/diff/ > > > Testing > ------- > > Manually tested. Unit tests pass. > > > Thanks, > > Aravindan Vijayan > >
