-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45753/
-----------------------------------------------------------

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-15470
    https://issues.apache.org/jira/browse/AMBARI-15470


Repository: ambari


Description
-------

decommission-allowed components are currently a hardcoded list in 
stack_service_component.js

isDecommissionAllowed: Em.computed.existsIn('componentName', ['DATANODE', 
'TASKTRACKER', 'NODEMANAGER', 'HBASE_REGIONSERVER']),

This should be stack driven by examine metainfo.xml looking for DECOMMISSION 
custom command or a designated flag.

Attachments


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
 c7ffe75 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
 8ea7569 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
a3e06a5 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
9fb3ef6 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml 
f910677 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
b445f28 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 
8f954c8 
  ambari-server/src/main/resources/properties.json c5f720a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 1612233 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 86fad13 
  ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/metainfo.xml 
d00b0b1 
  ambari-server/src/test/resources/stacks/HDP/2.0.5/services/YARN/metainfo.xml 
40e6957 
  ambari-server/src/test/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml 
2e02427 
  ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml 
de0b1c0 
  ambari-web/app/mappers/stack_service_mapper.js 6bcd6b5 
  ambari-web/app/models/stack_service_component.js 850088b 
  ambari-web/test/mappers/stack_service_mapper_test.js e999999 
  ambari-web/test/service_components.js e9791ff 

Diff: https://reviews.apache.org/r/45753/diff/


Testing
-------

new unit tests added to both front and backend code
patch a trunk cluster with front and backend code change and test the 
decommission command shown on the UI


Thanks,

Di Li

Reply via email to