-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45774/#review127208
-----------------------------------------------------------


Ship it!




Ship It!

- Richard Zang


On April 5, 2016, 8:46 p.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45774/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 8:46 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg 
> Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15720
>     https://issues.apache.org/jira/browse/AMBARI-15720
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AGGREGATE type alerts should not expose a repeat_tolerance or 
> repeat_tolerance_enabled setting in the web client. This is because of the 
> nature of how AGGREGATE alerts functions. They respond to HARD alert events 
> and are therefore simply a summary of the known alerts which have already 
> reached their repeat tolerance levels.
> These types of alerts will not honor a global repeat tolerance value 
> (cluster-env/alerts_repeat_tolerance nor will they honor changes to alert 
> definitions of source type AGGREGATE.
> They effectively have a tolerance of 1 always.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/models/alerts/alert_definition.js bdc8431 
>   ambari-web/app/templates/main/alerts/definition_details.hbs 95a8a08 
> 
> Diff: https://reviews.apache.org/r/45774/diff/
> 
> 
> Testing
> -------
> 
> Local ambari-web test passed.
> 25609 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Reply via email to