> On April 6, 2016, 7:04 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py,
> > line 113
> > <https://reviews.apache.org/r/45778/diff/1/?file=1326879#file1326879line113>
> >
> > Keep cmd as a list
command changed back to list type.
Initially I followed other examples on hive_service_interactive.py, such as:
pid_file = format("{hive_pid_dir}/{hive_interactive_pid}")
cmd = format("{start_hiveserver2_interactive_path}
{hive_pid_dir}/hive-server2-interactive.out
{hive_log_dir}/hive-server2-interactive.err {pid_file}
{hive_server_interactive_conf_dir} {hive_log_dir}"
- Juanjo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/#review127295
-----------------------------------------------------------
On April 5, 2016, 9:46 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45778/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 9:46 p.m.)
>
>
> Review request for Ambari and Jayush Luniya.
>
>
> Bugs: AMBARI-15577
> https://issues.apache.org/jira/browse/AMBARI-15577
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Featurize HDP specific logic from HIVE service
>
>
> Diffs
> -----
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
> f7d817a
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
> 41508b4
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
> 42485b6
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
> 941b70c
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
> 4153821
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
> 3c51d39
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
> ba2a129
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
> 7fee2b3
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
> f7f1377
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
> e1c0c42
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py
> 8045528
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
> 3aa6536
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
> 9f32d16
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
> 70b8921
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
> d71e061
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
> b95f6f3
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
> b0a876d
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
> 10e0990
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
> 7a3c12e
>
> Diff: https://reviews.apache.org/r/45778/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 253 tests in 6.681s
>
> OK
> ----------------------------------------------------------------------
> Failed tests:
> FAIL: test_stop_during_upgrade (test_hive_server.TestHiveServer)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/jmarron/git/ambari/ambari-common/src/test/python/mock/mock.py",
> line 1199, in patched
> return func(*args, **keywargs)
> File
> "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py",
> line 761, in test_stop_during_upgrade
> tries=1, user='hive')
> File
> "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
> line 262, in assertResourceCalledByIndex
> self.assertEquals(name, resource.name)
> AssertionError: 'hive --config /usr/hdp/current/hive-server2/conf/conf.server
> --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434' != 'hive --config
> /etc/hive/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434'
>
> ----------------------------------------------------------------------
> Total run:933
> Total errors:0
> Total failures:1
>
>
> Thanks,
>
> Juanjo Marron
>
>
