----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45778/#review127523 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py (line 52) <https://reviews.apache.org/r/45778/#comment190868> I wouldn't use stack_name_lowercase, just use stack_name everywhere. Do keep stack_name_uppercase - Alejandro Fernandez On April 6, 2016, 8:49 p.m., Juanjo Marron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45778/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 8:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jayush Luniya. > > > Bugs: AMBARI-15577 > https://issues.apache.org/jira/browse/AMBARI-15577 > > > Repository: ambari > > > Description > ------- > > Featurize HDP specific logic from HIVE service > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > f7d817a > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py > 4fc3489 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py > 42485b6 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py > 941b70c > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py > 4153821 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > 3c51d39 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py > ba2a129 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py > 7fee2b3 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py > f7f1377 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > e1c0c42 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py > 8045528 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py > 3aa6536 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py > 9f32d16 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 70b8921 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py > d71e061 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py > b95f6f3 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py > b0a876d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py > 10e0990 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 7a3c12e > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8d0467a > > Diff: https://reviews.apache.org/r/45778/diff/ > > > Testing > ------- > > mvn clean test -DskipSurefireTests > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [20.236s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.672s] > [INFO] Ambari Web ........................................ SUCCESS [1:44.395s] > [INFO] Ambari Views ...................................... SUCCESS [8.415s] > [INFO] Ambari Admin View ................................. SUCCESS [26.967s] > [INFO] ambari-metrics .................................... SUCCESS [0.875s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.270s] > [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.132s] > [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.734s] > [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [1.434s] > [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.894s] > [INFO] Ambari Metrics Collector .......................... SUCCESS [41.267s] > [INFO] Ambari Metrics Monitor ............................ SUCCESS [2.683s] > [INFO] Ambari Metrics Grafana ............................ SUCCESS [24.118s] > [INFO] Ambari Metrics Assembly ........................... SUCCESS [50.671s] > [INFO] Ambari Server ..................................... SUCCESS [1:07.610s] > [INFO] Ambari Functional Tests ........................... SUCCESS [1.088s] > [INFO] Ambari Agent ...................................... SUCCESS [12.194s] > [INFO] Ambari Client ..................................... SUCCESS [0.081s] > [INFO] Ambari Python Client .............................. SUCCESS [0.683s] > [INFO] Ambari Groovy Client .............................. SUCCESS [14.871s] > [INFO] Ambari Shell ...................................... SUCCESS [0.069s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.049s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [10.821s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 6:35.996s > [INFO] Finished at: Wed Apr 06 01:38:42 PDT 2016 > [INFO] Final Memory: 112M/721M > > > Thanks, > > Juanjo Marron > >
