> On April 6, 2016, 8:58 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-env.xml, > > line 61 > > <https://reviews.apache.org/r/45835/diff/1/?file=1328851#file1328851line61> > > > > Does this value need to change during a stack upgrade to HDP 2.5? > > Sriharsha Chintalapani wrote: > It will be good to have this changed during the upgrade
If this is going into Ambari 2.2.2, then we may want to modify RU/EU upgrade packs (or config packs) to change the value. > On April 6, 2016, 8:58 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py, > > line 124 > > <https://reviews.apache.org/r/45835/diff/1/?file=1328853#file1328853line124> > > > > If the property does not exist, does it need a default value? > > Sriharsha Chintalapani wrote: > isn't the default value come from storm-env.xml? If a customer is on HDP 2.2 and Ambari 2.1, then they upgrade Ambari to 2.2.2, then their storm-env hasn't changed. So perhaps the python script may not assume that this will always exist. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45835/#review127443 ----------------------------------------------------------- On April 6, 2016, 9:12 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45835/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 9:12 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Repository: ambari > > > Description > ------- > > AMBARI-15635. Storm & Kafka should've default nproc ,nofile values. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-env.xml > 3b910bb > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml > e9f4b28 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 4b4e776 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm.conf.j2 > PRE-CREATION > > Diff: https://reviews.apache.org/r/45835/diff/ > > > Testing > ------- > > Deployed Storm & Kafka with the above changes and noticed the nofiles and > noproc values change. > > > Thanks, > > Sriharsha Chintalapani > >
