> On April 6, 2016, 9:28 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-env.xml,
> >  line 61
> > <https://reviews.apache.org/r/45835/diff/1/?file=1328851#file1328851line61>
> >
> >     Shouldnt we update these values during ambari-server upgrade instead 
> > i.e. existing cluster value should be updated on upgrading ambari-server?

Perhaps not a blocker for the patch as we are close to the release. Users can 
change it manually.


- Sumit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45835/#review127461
-----------------------------------------------------------


On April 6, 2016, 9:12 p.m., Sriharsha Chintalapani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45835/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 9:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-15635. Storm & Kafka should've default nproc ,nofile values.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-env.xml
>  3b910bb 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml
>  e9f4b28 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
>  4b4e776 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm.conf.j2
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45835/diff/
> 
> 
> Testing
> -------
> 
> Deployed Storm & Kafka with the above changes and noticed the nofiles and 
> noproc values change.
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Reply via email to